Closed (won't fix)
Project:
Drupal core
Version:
6.x-dev
Component:
database system
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
16 Oct 2007 at 14:27 UTC
Updated:
21 Nov 2007 at 16:17 UTC
Jump to comment: Most recent file
This is a split version of previous patch: http://drupal.org/node/178555. This patch only consider about the simple tidy up of database.inc: update comment, and reorder some code (since %% should be remove within D7 with the help of PDO). Should be trivial to commit.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drupal-6.x-dev-database-0.4.patch | 1.29 KB | hswong3i |
| #2 | drupal-6.x-dev-database-0.3.patch | 1.29 KB | hswong3i |
| #1 | drupal-6.x-dev-database-0.2.patch | 1.29 KB | hswong3i |
| drupal-6.x-dev-database-0.1.patch | 1.16 KB | hswong3i |
Comments
Comment #1
hswong3i commentedThis patch is quite simple, but also reroll via latest CVS HEAD, plus testing case as like as http://drupal.org/node/183896 and http://drupal.org/node/183892. All pass without error (for sure...)
P.S. Since I am still finding the possibility (not only in D7, but also the chance for D6...) of remove the complicated
'%s'syntax, remove%%placeholder (should be no longer supported when using PDO as backend), and the promote of CLOB based on the help of handy abstraction by using drupal_write_record() and schema API (so Oracle may also have possibility to implement as a "drop-in" driver), this syntax cleanup and document update will give a hand to my current research: patch will able to be smaller and simpler ;pComment #2
hswong3i commentedPatch reroll via latest CVS HEAD. It is simple enough, with no critical logic change, and ready for commit. May someone give me a hand?
Comment #3
hswong3i commentedPatch reroll via latest CVS HEAD. Already merge with #172541 for D7 preparation, so shouldn't be too hurry right now.
Comment #4
hswong3i commentedNothing will happened even without this cleanup. Don't waste time in here.