Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views_ui.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Nov 2012 at 19:10 UTC
Updated:
29 Jul 2014 at 21:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ryan.ryan commentedpostponed until post-D8 feature freeze.
Comment #1.0
ryan.ryan commentedadding correct urls and updating summary
Comment #2
tim.plunkettFixing tags. Thanks for filing this!
Comment #3
dead_armGeneral:
Color hex values should follow Drupal coding standards (lowercase letters)
Change floats to inline-block where appropriate
In views-admin.theme.css
#edit-display-settings main should not have a margin top of 15px, rather the #edit-display-settings-top should have a margin bottom
#view-edit-form #edit-displays should have a bottom margin to separate the edit and preview areas and #views-preview-wrapper should not have 2 border styles, so we should remove the border-top 2px style
#views-live-preview cramping update preview button, needs more left margin
Comment #4
xjmComment #5
dead_armPatch with changes to clean up items from comment 3.
Comment #6
tim.plunkettAbout half of that is fixing the case/length on hex colors, but there are a few real changes.
We have the before shots in #3, can we have some after?
Comment #7
dead_armScreenshots of changes.

Comment #9
tim.plunkettCSS breaking Drupal\system\Tests\Common\HttpRequestTest? Hah.
Those fixes look good, and the screenshots look great!
Comment #10
webchick#5: vdc-1840896-5.patch queued for re-testing.
Comment #11
droplet commentedIs it clean up everything? (or fixing bugs from #1806022)
few more:
e.g
shorthand
Remove unnecessary qqualified selectors
..etc.
Comment #12
tim.plunkett@droplet, for those, you'd need to manually test each of those in all 3 themes. Feel free to open an issue.
Comment #13
webchickThese look pretty straight-forward.
Committed and pushed to 8.x. Thanks!
Comment #14.0
(not verified) commentedusing correct project issue syntax.