Problem/Motivation

As per comment 51 at #1806022: Views' text color does not have sufficient contrast, general CSS changes and fixes such as those made in 43 of the same issue should wait until after the feature-freeze.

Comments

ryan.ryan’s picture

postponed until post-D8 feature freeze.

ryan.ryan’s picture

Issue summary: View changes

adding correct urls and updating summary

tim.plunkett’s picture

Component: CSS » views_ui.module
Priority: Minor » Normal
Issue tags: -#views +VDC

Fixing tags. Thanks for filing this!

dead_arm’s picture

StatusFileSize
new19.47 KB
new14.06 KB
new16.44 KB

General:
Color hex values should follow Drupal coding standards (lowercase letters)
Change floats to inline-block where appropriate

In views-admin.theme.css
#edit-display-settings main should not have a margin top of 15px, rather the #edit-display-settings-top should have a margin bottom

views-edit-displays.png

#view-edit-form #edit-displays should have a bottom margin to separate the edit and preview areas and #views-preview-wrapper should not have 2 border styles, so we should remove the border-top 2px style

views-preview-wrapper.png

#views-live-preview cramping update preview button, needs more left margin

views-live-preview-button.png

xjm’s picture

Status: Postponed » Active
dead_arm’s picture

Status: Active » Needs review
StatusFileSize
new8.34 KB

Patch with changes to clean up items from comment 3.

tim.plunkett’s picture

Issue tags: +Needs screenshots

About half of that is fixing the case/length on hex colors, but there are a few real changes.

We have the before shots in #3, can we have some after?

dead_arm’s picture

Screenshots of changes.
Screen Shot 2012-12-19 at 2.12.09 PM.png

Screen Shot 2012-12-19 at 2.13.34 PM.png

Status: Needs review » Needs work

The last submitted patch, vdc-1840896-5.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Reviewed & tested by the community

CSS breaking Drupal\system\Tests\Common\HttpRequestTest? Hah.

Those fixes look good, and the screenshots look great!

webchick’s picture

#5: vdc-1840896-5.patch queued for re-testing.

droplet’s picture

Is it clean up everything? (or fixing bugs from #1806022)

few more:

e.g

shorthand

.views-admin .icon,
.views-admin .icon-text {
  background-attachment: scroll;
  background-image: url("../images/sprites.png");
  background-position: left top; /* LTR */
  background-repeat: no-repeat;
}

Remove unnecessary qqualified selectors

th.views-ui-name {
  width: 18%;
}
ul#views-display-menu-tabs {
  margin-right: 200px;
}

..etc.

tim.plunkett’s picture

@droplet, for those, you'd need to manually test each of those in all 3 themes. Feel free to open an issue.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

These look pretty straight-forward.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

using correct project issue syntax.