Windows Azure Authentication

very well written code!

I reviewed the code manually and can find only one small issue: Please add a "configure" line to your info file that links to your configuration form you registered within the menu hook.

Automatic review: http://ventral.org/pareview/httpgitdrupalorgsandboxr2integrated1842766git

- the naming error is a false positive
- the other potential problem within the azure_auth.pages.inc is not solvable using form api because it gets called from the outside, right?

Hello,

Here is my manual review:
azure_auth.module: line 256, use db_select() instead of db_query().
Also please fix issues that automatic test found http://ventral.org/pareview/httpgitdrupalorgsandboxr2integrated1842766git
Other files are good written.

@drupalrv As mentioned above most ventral issues are false positives, only the last one is correct.

@r2integrated Please use db_select() and fix the last formatting issue raised by the ventral.org mechanism.

manual review:

1. azure_auth.api.inc should be named azure_auth.api.php
2. azure_auth_uninstall(): this is a hook and should be documented as such, see http://drupal.org/node/1354#hookimpl
3. azure_auth_user_insert(): check_plain() is not necessary here as you are not printing anything to the user? "When handling data, the golden rule is to store exactly what the user typed. When a user edits a post they created earlier, the form should contain the same things as it did when they first submitted it. This means that conversions are performed when content is output, not when saved to the database" see http://drupal.org/node/28984
4. azure_auth_block_view(): no need to use module_load_include as you are including files from your own module which you already know where they are. Use something like require_once 'mymodule.inc';
5. "t(variable_get('azure_auth_link_text', 'Sign in using Windows Azure')": t() should be used around string literals where possible, not around user provided data.
6. "interface IAzureAuthenticationToken": interfaces should not be prefixed with "I" but postfixed with "Interface", see http://drupal.org/node/608152

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

now actually removing tag ;-)

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/azure_auth.pages.inc
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   24 | ERROR | Invalid @param data type, expected bool but found boolean
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• "'#title' => t(variable_get('azure_auth_link_text', 'Sign in using Windows Azure')),": another instance where t() should be used directly on the literal string.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

no objections for more than a week, so ...

Thanks for your contribution, r2integrated!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.