Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Nov 2012 at 13:54 UTC
Updated:
10 Sep 2018 at 00:30 UTC
Jump to comment: Most recent
Comments
Comment #1
nesta_ commentedREADME.txt is missing, see the guidelines for in-project documentation.
Comment #2
Julian Maurice commentedThanks for the review.
I just added the README.txt and checked one by one items of Ventral Project Application Checklist (http://ventral.org/pachecklist).
This should be ok now.
Comment #3
nesta_ commented:) thnx!
Comment #4
bhosmer commentedThe module description is somewhat vague. Could you provide a bit more on your project page about what your module does and why users might want to use it?
Also, could you somehow set up a demo catalog to connect to so that the module could be tested?
I also wonder about the koha.conf file. Could this be stored using variable_set instead? It is a little cumbersome for a site builder to have to edit a configuration file located on the server in order to enable and set up this module.
Comment #5
Julian Maurice commentedI added a brief description of OPAC module on the project page, but I don't know how I could be more explicit. OPAC module has to deal with ILS of different types. For this purpose it needs connectors. This module is one connector, which allow OPAC to deal with Koha ILS. That's all users have to know about it (before downloading it). Documentation about what connectors do can be found in OPAC module documentation.
What do you want to see on this project page?
I'm afraid Koha connector cannot be really tested without admin access (to Drupal and to the server that host it) and I cannot provide you this access.
But you can test it by:
Then you can test harvesting bibliographic and authority records from Koha (with drush commands), displaying items of bibliographic records, authenticate to Drupal and then look at your own holds and checkouts, place hold on bibliographic records, ...
How could the site builder edit the variable then?
For now, we want to keep the configuration in a file. This is a more convenient way to edit, share and compare configurations. Maybe in a future version OPAC module will allow connectors to declare configuration forms or something like that, but this is not planned yet.
Comment #6
Julian Maurice commentedComment #7
Tredok commentedHello,
I'm testing koha_connector and opac module. When I tried to configure Content types from OPAC Servers, I have an error (cf. http://www.flickr.com/photos/tredok/8266103157). Idem whith "Wiew".
- Drupal 7
- opac modules : 7.x-1.x-dev
- koha_connector : via git
- Koha : 3.8.5
Comment #8
Claire Hernandez commentedCould you give me the result of
$ git log -1
in opac and koha_connector please ?
Comment #9
Tredok commentedI've used git locally to donwload modules in my hdd. Then, I've uploader them in my server (shared on OVH).
Are you still interresting ?
Comment #10
Claire Hernandez commentedTredok, koha_connector issue system => http://drupal.org/node/1868246
(This issue can become again a review issue.)
Comment #11
Claire Hernandez commentedDear reviewers, I need to translate the module, would you have best practices to share a po. I think a module to be translated need a full project, isn't it ?
The module goes in production for many customers in very few weeks and for me the priority increase but I don't really know how to use the input "priority", does it depends of the maintainers point of view ?
Comment #12
bhosmer commentedYou might want to check out this page: http://drupal.org/documentation/multilingual
Comment #13
PA robot commentedProject 1: http://drupal.org/node/1917088
Project 2: http://drupal.org/node/1844646
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message.
Comment #14
PA robot commentedWe are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #15
Julian Maurice commentedComment #15.0
Julian Maurice commentedadded automated review link
Comment #16
avpaderno