If you clone a matching question using the node_clone module (http://drupal.org/project/node_clone), the cloned matching question will lose all of the existing answer/question/feedback sets.

I have attached a patch that fixes this issue by checking if it is a new question before updating the existing matches. This fixes this issue without changing an other use cases behaviors.

CommentFileSizeAuthor
#4 quiz_matching_clone.patch877 bytesganesan g
0001-Fix-bug-where-node_clone-module-would-lose-all-match.patch1.3 KBmichaelk

Comments

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Node Clone

For me answer/question/feedback sets are preserved irrespective of the above patch. Could be something to do with your clone configuration? but it just works the way expected for me.

michaelk’s picture

michaelk commented
Status: Postponed (maintainer needs more info) » Needs review

Here is some more info about our specific setup where we are experiencing the issue.

We have Node Clone module configured with the "Pre-populate the node form fields" method of cloning on the /admin/config/content/clone configuration page.

Then we create a matching question with some questions, answers, and feedback.

Then we clone that matching question without modifying any of the fields on the clone node form, and all of the question/answer/feedback sets are lost in the new question.

ganesan g’s picture

ganesan g commented
Issue summary: View changes

@michaelk Since the patch which you gave is old one, I have uploaded the recent patch which is also doing the same. The patch is working fine.
@sivaji please review the patch.

ganesan g’s picture

ganesan g commented
StatusFileSize
new quiz_matching_clone.patch877 bytes

Here is the recent patch

falcon’s picture

falcon commented
Component: Code - matching » Code - Quiz core
Status: Needs review » Needs work

Patch does not apply any more and needs to be re-rolled against 7.x-4.x branch

  • smustgrave committed 17b9bbb8 on 7.x-5.x 
    Issue #1845208 by ganesan g, michaelk: Matching Question Type Loses...
smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

With D7 EOL soon going through the D7 queue here. This fix seemed small enough that I didn't mind committing it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.