Still no admin mail

If you replace the code that has to be inserted to

//This bit of code taken from EC4 to allow mails to be sent on order submission
foreach (module_implements('checkoutapi') as $module) {
$function = "{$module}_checkoutapi";
function_exists($function) && $function($txn, 'post_process');
}
//End code insertion

It works properly. Somehow the salemail does not appear in the $txn->review_screens of the original code:

foreach ($txn->review_screens as $module) {
..
}

Also inserting it before the block (in cart.module)

// If the transaction is done, tell them and send them home
if ($txn->gross <= 0) {
store_send_invoice_email($txn->txnid);
drupal_set_message(t('Your order has been submitted.'));
return '';
}

the admin will always receive a notification, even when free items are ordered.

Forgot to mention above is for the ecommerce-5.x-3.x branch of eCommerce.

Hi,

Got the solution for the last issue, the missing mailid.

Solution is to add an installation file called 'salemail.install' containing the following code:

<?php
// $Id: salemail.install,v 1.20.2.1.2.12.2.11 2007/07/27 13:10:56 gordon Exp $

require_once(drupal_get_path('module', 'store') . '/store.deps.inc');

/**
 * E-Commerce salemail.module schema
 */
function salemail_install() {

  // builds initial mail into the system
  require_once(drupal_get_path('module', 'ec_mail') . '/ec_mail.module');
  
  // include the install's own module so that the constants are defined. 
  require_once(drupal_get_path('module', 'salemail') .'/salemail.module');
  ec_mail_reset_to_defaults(ECMAIL_TYPE_ADMIN_SALE_NOTIFY, 'salemail');

  drupal_set_message(t('SALEMAIL module installed successfully.'));
}
?>

This code might throw some warnings about array_merge() which i think are caused by a harmless bug in e-Commerce:ec_mail.module (it does not check if the thing it excepts is an array indeed).