Posted by itarato on November 22, 2012 at 3:26pm
6 followers
| Project: | Hierarchical Select |
| Version: | 7.x-3.0-alpha5 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
I have a feature which is turned on in an installation profile. At the end of the install phase it breaks with an error message:
( ! ) Fatal error: Call to undefined function hierarchical_select_common_config_set() in ../sites/all/modules/contrib/hierarchical_select/hierarchical_select.features.inc on line 93
Call Stack
# Time Memory Function Location
1 0.0005 250904 {main}( ) ../install.php:0
2 0.0051 624656 install_drupal( ) ../install.php:26
3 0.1722 6142784 install_run_tasks( ) ../install.core.inc:77
4 19.4952 51510088 install_run_task( ) ../install.core.inc:339
5 19.4952 51512056 goto_base_features_rebuild( ) ../install.core.inc:470
6 19.4952 51512088 features_rebuild( ) ../goto_base.install:272
7 19.4952 51512304 _features_restore( ) ../features.module:893
8 21.5809 54422312 features_invoke( ) ../features.module:871
9 21.5809 54422952 call_user_func_array ( ) ../features.module:516
10 21.5809 54423376 hierarchical_select_features_rebuild( ) ../features.module:516
Comments
#1
Here you are a patch. Please consider merging it. Let me know if you anything from me.
Thanks!
#2
Patch applied clean & fixed the problem!
Thank you!
#3
Works for me, as well.
#4
The patch seems reasonable but a more comprehensive test and example would be great. Maybe provide a feature or some steps how to reproduce this.
#5
Worked as expected for me.
@Kars-T - I see where you're coming from, but for a one-line patch that is pretty clean-cut I think it might be worthwhile to get this into the codebase so others using Features don't keep running into this. I'm switching to RTBC, but definitely defer to you on this if you want to swap back. Just my two cents! :)
#6
hierarchical_select_features_rebuild()calls a function that is not yet available. Attached patch ensures that required function is available. I agree with RTBC.Does that make sense to you too, Kars-T?
#7
Yes it made sense to me as I read the patch ;)
But I think that it the responses like "Works! :D" are okay but don't give detail so I asked about more detail so a maintainer doesn't need to think through it so much. Okay it is a one liner and if the function is not there why not just include?
So RTBC is fine :)