I have a feature which is turned on in an installation profile. At the end of the install phase it breaks with an error message:

( ! ) Fatal error: Call to undefined function hierarchical_select_common_config_set() in ../sites/all/modules/contrib/hierarchical_select/hierarchical_select.features.inc on line 93
Call Stack
#	Time	Memory	Function	Location
1	0.0005	250904	{main}( )	../install.php:0
2	0.0051	624656	install_drupal( )	../install.php:26
3	0.1722	6142784	install_run_tasks( )	../install.core.inc:77
4	19.4952	51510088	install_run_task( )	../install.core.inc:339
5	19.4952	51512056	goto_base_features_rebuild( )	../install.core.inc:470
6	19.4952	51512088	features_rebuild( )	../goto_base.install:272
7	19.4952	51512304	_features_restore( )	../features.module:893
8	21.5809	54422312	features_invoke( )	../features.module:871
9	21.5809	54422952	call_user_func_array ( )	../features.module:516
10	21.5809	54423376	hierarchical_select_features_rebuild( )	../features.module:516
CommentFileSizeAuthor
#1 hierarchical_select_1847974_1_unloaded_common_inc.patch594 bytesitarato

Comments

itarato’s picture

itarato commented
Status: Active » Patch (to be ported)
StatusFileSize
new hierarchical_select_1847974_1_unloaded_common_inc.patch594 bytes

Here you are a patch. Please consider merging it. Let me know if you anything from me.
Thanks!

seyv’s picture

seyv commented
Status: Patch (to be ported) » Reviewed & tested by the community

Patch applied clean & fixed the problem!
Thank you!

pinolo’s picture

pinolo
he/him
commented

Works for me, as well.

kars-t’s picture

kars-t commented
Assigned: itarato » Unassigned
Status: Reviewed & tested by the community » Needs review

The patch seems reasonable but a more comprehensive test and example would be great. Maybe provide a feature or some steps how to reproduce this.

sokrplare’s picture

sokrplare commented
Status: Needs review » Reviewed & tested by the community

Worked as expected for me.

@Kars-T - I see where you're coming from, but for a one-line patch that is pretty clean-cut I think it might be worthwhile to get this into the codebase so others using Features don't keep running into this. I'm switching to RTBC, but definitely defer to you on this if you want to swap back. Just my two cents! :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

hierarchical_select_features_rebuild() calls a function that is not yet available. Attached patch ensures that required function is available. I agree with RTBC.

Does that make sense to you too, Kars-T?

kars-t’s picture

kars-t commented

Yes it made sense to me as I read the patch ;)

But I think that it the responses like "Works! :D" are okay but don't give detail so I asked about more detail so a maintainer doesn't need to think through it so much. Okay it is a one liner and if the function is not there why not just include?

So RTBC is fine :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed.

http://drupalcode.org/project/hierarchical_select.git/commit/8f238d7

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.