After this got in #1553114: Adding files should be a multi-step process now there is no need to have the edit modal form

CommentFileSizeAuthor
#1 media-remove_edit_modal_after_upload-1848034-1.patch2.96 KBParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new media-remove_edit_modal_after_upload-1848034-1.patch2.96 KB
arthurf’s picture

arthurf commented

Tested this with new and existing media and seems to work correctly. Nice to see another file get removed!

Is the next logical issue to address the ctools modal for a file field edit?

ParisLiakos’s picture

ParisLiakos commented

Is the next logical issue to address the ctools modal for a file field edit?

what do you mean with address?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I'm not sure what we can do with the 'Edit' button yet?

arthurf’s picture

arthurf commented

I think it's strange that we have two different styles of interfaces for dealing with files- ctools modal and the media modal. It's beyond the scope of this issue so I'll hush up for now.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Yeah I guess we could open an issue to use our custom modal with the Edit file button, but the hope was to reduce code we have to maintain. I think a better issue would be to style the ctools modal to "look" like our custom modal for now (as a separate issue).

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Fixed

i went ahead and committed #1 since this is quite a usability improvement
http://drupalcode.org/project/media.git/commit/156399b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gmclelland’s picture

gmclelland commented

Did anyone open up a followup issue as per @Dave Reid's suggestions in #6 to style the ctools modal dialog to look like media module's modal dialog?