In the new branch 2.x, we should only support the file field.

Note: We should not just change media_gallery_media from media to file field, as 1.1.x installations will not be able to upgrade.

CommentFileSizeAuthor
#5 media_gallery-change-to_file_field-1848914-5.patch21.17 KBmoloc
#4 media_gallery-change-to_file_field-1848914-4.patch20.03 KBmoloc
#2 media_gallery-change_to_file_field-1848914-2.patch27.67 KBmoloc
#1 media_gallery-change_to_field_field-1848914-1.patch24.36 KBmoloc

Comments

moloc’s picture

moloc commented
Status: Active » Needs review
StatusFileSize
new media_gallery-change_to_field_field-1848914-1.patch24.36 KB

untested patch

Move in 2.x branch from media field to file field.

moloc’s picture

moloc commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
StatusFileSize
new media_gallery-change_to_file_field-1848914-2.patch27.67 KB

tested & updated patch

moloc’s picture

moloc commented

Maybe it is better to not rename all functions to be more backward compatible. So users which upgrade do not have to update their own code, overriding theme functions.

moloc’s picture

moloc commented
StatusFileSize
new media_gallery-change-to_file_field-1848914-4.patch20.03 KB

New version, without changing theme functions.

I think, this is ready to commit now. ([edit] untested[/edit])

moloc’s picture

moloc commented
StatusFileSize
new media_gallery-change-to_file_field-1848914-5.patch21.17 KB

add fixes for lightbox in javascript and css

moloc’s picture

moloc commented
Status: Needs review » Fixed

Committed to 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

softone’s picture

softone commented

It seems there is no upgrade path from 7.x-1.0-beta8 to 7.x-2.x-dev.

media_gallery_media field remains and is of type media.
This breaks the rest of the code.

Should this issue be reopened or should a new one be created?