Commerce Currency Settings

Hi facine,

Thanks for submitting a project application for review. To help you track the status of your application you might want to enable email notifications for changes to your application:

http://drupal.org/project/issues/subscribe-mail/projectapplications

You might also want to participate in the review bonus program - this should help ensure your application is review quickly:

http://drupal.org/node/1410826

The PAReview tool identified a few issues which you may want to look at (although nothing major):

http://ventral.org/pareview/httpgitdrupalorgsandboxfacine1850086git

Manual review:

Minor: In commerce_currency_settings_menu you define menu items for both Currency Settings and Custom Currency Settings - the first doesn't seem to have any callback args. Is this in use? Are both required?

Minor: Possible typo in method name - commerce_currency_settings_element_validate_fuction - should this be commerce_currency_settings_element_validate_function?

On the whole this looks like a pretty nice piece of code. The previously mentioned Drupal Sniffer issues are pretty minor too and should be easily fixable.

Can you please check/fix the above issues? Once done change the status to "needs review"

Hi Facine,

This is looking pretty nice :-). I've taken a look through the module and had a quick play around with it on patrickd's awesome testing site - all seems to work fine to me.

Thanks for clearing up the item in commerce_currency_settings_menu - I can see what its being used for now.

I did check for duplicate modules. About the nearest I can find is Commerce Multicurrency, though it seems more concerned with synchronizing exchange rates and less with formatting as your module is.

There's a minor PAReview error - please ensure you leave a blank line at the end of your files. Nothing that would stop a RTBC though...

I'm assigning RTBC - please let me know if I've missed anything.

I believe at this point an administrator will be needed to set your project to closed (fixed) and grant full project creation permissions. I'd definitely recommend taking part in the review bonus program:

http://drupal.org/node/1410826

This should ensure an administrator is summoned quickly to this request and hopefully get you sorted quickly :-)

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/commerce_currency_settings.module
  --------------------------------------------------------------------------------
  FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
  --------------------------------------------------------------------------------
   250 | ERROR | Invalid @param data type, expected bool but found boolean
   252 | ERROR | Invalid @param data type, expected bool but found boolean
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. commerce_currency_settings_install(): do not juggle with module weights, this is not reliable. Use hook_module_implements_alter() instead to arrange the ordering of a specific hook you want to go for.
2. commerce_currency_settings_settings_form_validate(): why do you need to clear the cache in a validation function? Also it looks like you are not doing any validation in this function, looks more like a submit handler?

But that are not application blockers, so ...

Thanks for your contribution, facine!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.