Posted by ianmthomasuk on November 27, 2012 at 5:35pm
1 follower
| Project: | Feeds |
| Version: | 7.x-2.x-dev |
| Component: | Documentation |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
In FeedsSource::import() there is an exception block that ends
catch (Exception $e) {
// Do nothing.
}in fact, this exception is being stored and re-thrown after we've had a chance to do some clean up (a bit like a finally block that doesn't require PHP 5.5). The comment (and any similar comments) should be corrected to reflect this.
Comments
#1
Here is a patch for the two examples I was able to find.
Replaces the "Do nothing" comment with one saying "$e is stored and re-thrown once we've had a chance to log our progress"
#2
Any chance of getting this committed? It's just a comment change, and it would be a shame if it bitrotted or confused anyone else.