Remove unused node_load

douggreen - October 21, 2007 - 19:52
Project:Organic groups
Version:5.x-4.0-rc11
Component:og.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The patch removes an unused node_load in og_save_subscription(). The extra node_load actually causes a problem, that I haven't completely tracked down. But since the node_load isn't need I hope it can just be removed.

The problem occurs when node_submit() is called via drupal_execute to auto-submit a CCK content type that is og-enabled. When this happens, nodapi insert gets called which goes down this path and calls og_save_subscription, which calls node_load, which loads the form it's saving, which somehow messes up the node that is being saved.

As I said, I haven't completely tracked it down yet, ... but the og but is pretty simple ... there's an extraneous node_load being called, and it should be removed.

AttachmentSize
extra-node-load.patch881 bytes

#1

moshe weitzman - October 23, 2007 - 01:50
Status:needs review» fixed

committed. thx.

#2

Anonymous - November 12, 2007 - 22:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.