Closed (cannot reproduce)
Project:
Drupal Commons
Version:
7.x-3.2
Component:
Wikis
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Nov 2012 at 03:30 UTC
Updated:
2 Jun 2014 at 19:06 UTC
Jump to comment: Most recent
Comments
Comment #1
ezra-g commentedCan you post steps to reproduce? I'm not able to do so. In general, Commons Wikis should be enabled as part of the default Commons install.
Comment #2
mixxmac commentedHi....
I think this may have something to do with the bean module. I started getting it after enabling Bean and Bean Admin UI (7.x-1.1) on Commons 7.x-3.2.
Then, enabling another module produces this error...
Notice: Undefined index: access callback in commons_wikis_menu_alter() (line 50 of commons_wikis/commons_wikis.module). Backtrace:
commons_wikis_menu_alter(Array, NULL, NULL, NULL) module.inc:1063
drupal_alter('menu', Array) menu.inc:2753
menu_router_build() menu.inc:2713
menu_rebuild() bean.module:389
bean_reset() bean_admin_ui.module:173
bean_admin_ui_modules_enabled(Array)
call_user_func_array('bean_admin_ui_modules_enabled', Array) module.inc:857
module_invoke_all('modules_enabled', Array) module.inc:499
module_enable(Array, ) system.admin.inc:1213
system_modules_submit(Array, Array) form.inc:1464
form_execute_handlers('submit', Array, Array) form.inc:860
drupal_process_form('system_modules', Array, Array) form.inc:374
drupal_build_form('system_modules', Array) form.inc:131
drupal_get_form('system_modules')
call_user_func_array('drupal_get_form', Array) menu.inc:517
menu_execute_active_handler() index.php:21
Comment #3
mixxmac commentedAnother similar error related to bean_admin_ui and link module in commons...
Notice: Undefined index: title_value in link_field_update_instance() (line 1305 of ... commons/profiles/commons/modules/contrib/link/link.module). Backtrace:
link_field_update_instance(Array, Array)
call_user_func_array('link_field_update_instance', Array) module.inc:857
module_invoke_all('field_update_instance', Array, Array) field.crud.inc:560
field_update_instance(Array) features.field.inc:298
field_instance_features_rebuild('commons_radioactivity', 'field_instance')
call_user_func_array('field_instance_features_rebuild', Array) features.module:534
features_invoke('field_instance', 'features_rebuild', 'commons_radioactivity') features.module:889
_features_restore('rebuild', Array) features.module:915
features_rebuild() features.module:239
features_flush_caches()
call_user_func_array('features_flush_caches', Array) module.inc:857
module_invoke_all('flush_caches') common.inc:7420
drupal_flush_all_caches() bean_admin_ui.admin.inc:184
bean_admin_ui_type_form_submit(Array, Array) form.inc:1464
form_execute_handlers('submit', Array, Array) form.inc:860
drupal_process_form('bean_admin_ui_type_form', Array, Array) form.inc:374
drupal_build_form('bean_admin_ui_type_form', Array) form.inc:131
drupal_get_form('bean_admin_ui_type_form')
call_user_func_array('drupal_get_form', Array) menu.inc:517
menu_execute_active_handler() index.php:21
Comment #4
cstillwell commentedI am also seeing this bug, or at least the access callback one. I haven't seen the title_value issue from #3.
Steps to reproduce:
Start with a fresh Drupal Commons site (I used the 7.x-3.2 tarball).
Download the Bean module.
Enable Bean (bean) and Bean Admin UI (bean_admin_ui).
Visit Structure -> Block Types, and click the Add block type button.
Fill in a value for the Label field (and maybe Description) and save the block type.
That should generate the notice in question. It should be in the message area after saving, and also in the recent logs. (Anything that triggers hook_menu_alter() should cause the error, though.)
Looking at commons_wikis_menu_alter(), it looks like the function is trying to find nodes which use revisions by looking for paths containing "revisions". And if such a path is found, any existing "access callback" on that path is replaced with "commons_wikis_user_revision_access" (with the old "access callback" being stored in "access arguments").
I think the actual "Undefined index" bug happens because not all of Bean's paths have explicit access callbacks set. I think some of the access callbacks are inherited instead. You can make the bug go away if you check that "$items[$route]['access callback']" is set before trying to add it to "access arguments".
I think there's a further issue in that Bean blocks are entities (defined via the entity API) and use revisions, so they get caught by commons_wikis_menu_alter(), but they aren't nodes. So it may not be appropriate to replace their callbacks.
Comment #5
lsolesen commentedSetting to fixed, as I cannot reproduce this on latest dev.