Weibo connect

Hi lixiphp,

The are some issues you need to fix. Check here for more information:
http://ventral.org/pareview/httpgitdrupalorgsandboxlixiphp1856380git

Here you can find information about Drupal's coding standards:
http://drupal.org/node/318

Please fix these issues before changing the status back to "needs review"

Here is an issue i 've found and i think you will improve your module if you fix it:
Your module's documentation asks for manually downloading the third party library named "sina weibo sdk" inside the folder "thirdparty".
It would be much better if you modified your module to use libraries (http://drupal.org/project/libraries) and include this third party library from the libraries folder. You need to keep third patry libraries out of your module's directory and use the same libraries with other modules.

You also need to change the project's branch name. The branch name should match the version of drupal that your module is for. In your case the branch must be 6.x-1.x. So, merge your code to the new branch and then remove the master branch. You can find some help on how to create a new branch and delete the old one here: http://drupal.org/node/1066342

Hi Lixi,

Tested your demo site with a fresh new registered Sina Weibo account. Got an error, attached. I have also edited your issue summary a little bit.

@Lixi, Tested again, it is working. Thanks.

1. We do not set status to "reviewed & tested by the community" by ourselves. So I changed it back.

2. It needs some more senior members to do a final review and then move on to next step.

3. Doing some bonus review may help to get your process faster. http://drupal.org/node/1410826

Hi guys,

Thanks very much for contributing this great and very interesting module.

It seems that Chinese Social Networks Authentication (CSNA) provides very similar functionality. Could you describe how your module differs?
We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

It seems this project application would be for Drupal 6, so maybe you could consider collabotating with Chinese Social Networks Authentication (CSNA) project maintainers and suggest some patches or ports for the Drupal 6 version.
Also, if this project application implements any particular feature that Chinese Social Networks Authentication (CSNA) doesn't, we could perhaps add Feature requests in CSNA's tracker.

The Chinese Social Networks Authentication (CSNA) provides an API for developers to integrate other Chinese Social Networks Authentication providers and if there are any third party authentication services that you would like to add, you might be interested in taking a look at the hooks provided by the CSNA API.

We would surely be glad to hear your opinion, comments or suggestions about these modules and how we could potentially group our efforts.

We would greatly appreciate any of your questions, comments, suggestions, recommendations or particular issues on this similar module, or any aspects of this comment.

Thanks again for your contributions and work.
Cheers!

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Updated issue summary.