It would be easier for CSS theming if block content was wrapper like this:

<section id=...>
  <div class="block-content">
    <span>block content...</span>
  </div>
</section>

Themes like AdaptiveTheme and Zen do that.

Comments

andregriffin’s picture

andregriffin commented

Hm, well I think the idea here was to provide the minimal amount of markup required to style basic elements with Bootstrap classes. For anyone who needs a deeper css selector for whatever reason is free to add inner divs as necessary. That's why the tpls are there. But I'm not sure it's necessary to add this extra markup by default. Does that seem reasonable?

cthiebault’s picture

cthiebault commented

I understand your point... and it what I did in fact.
But we could add a theme setting to add content wrappers (I think Zen does something like this).
If I have time, I'll try to submit a patch.

andregriffin’s picture

andregriffin commented
Status: Active » Closed (won't fix)

Sure, although adding this with a theme-setting, instead of just working with tpls I think may be overkill/unnecessary. Maybe I'm in the wrong here, but I like encouraging themers to get their hands dirty in the tpl files rather than use toggles/theme-settings to do simple modifications like these. I'm going to close this for now, but if you feel like submitting a patch for review later, feel free to reopen. Thanks.