Toolbar Paths

Hello,

You are using the master branch of git, you need to be using a version specific branch. Good article here.

There is no need for the license.txt file. Drupal will add that for you.

Your info file contains some lines that were added by the drupal packaging script, not sure why those are there, but I am pretty sure they shouldn't be there.

There are also a few errors shown here: http://ventral.org/pareview/httpgitdrupalorgsandboxohadsh5351858152git

Hi,

README.txt
change line #13 admin/config/user-interface/toolbar-paths to "Configuration > User interface > Toolbar Paths"

In the function toolbar_paths_settings, please use t() function for descriptions. Also remove unnecessary line break before return statement.

Hi ohadsh535,

Thanks very much for contributing this very nice module and fixing the coding standards errors.

I have reviewed your module quickly and didn't find any particular issues, except one comment I would have:

In file toolbar_paths.module, at lines 74:

function toolbar_paths_settings() {
  $form = array();

  $form['toolbar_paths_mode'] = array(
  ...

I was wondering if you could perhaps consider moving this code out of the toolbar_paths.module.
The function toolbar_paths_settings would be moved to toolbar_paths.admin.inc.
You could then add a call to this file in the menu callback that actually calls this form, so pretty much after line 32:

function toolbar_paths_menu() {
...
    'access arguments' => array('Administer Toolbar Paths'),
+    'file' => 'toolbar_paths.admin.inc',
  );
  return $items;
}

If you made this change it would slightly optimize the memory footprint upon execution of the module, which I guess it something probably quite important to get a validation here.

So far, that's all I could find, but I will keep looking and certainly let you know if I can find anything else.
I hope this comment will help you to improve this nice module.

Cheers!

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1859944
Project 2: http://drupal.org/node/1858950

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Fixed the git branch link.