In notify_update_2() the menu cache is cleared which is done using update.php anyway: http://api.drupal.org/api/function/update_do_updates/5

In my opinion notify_update_2() can be removed completely. The message in there should be part of the changelog only as it not a dynamic feedback of the update process.

CommentFileSizeAuthor
#1 notify-update.patch764 bytesStandart

Comments

Standart’s picture

Priority: Normal » Minor
Status: Active » Reviewed & tested by the community
StatusFileSize
new764 bytes
beginner’s picture

Status: Reviewed & tested by the community » Fixed

Oh I see. Good point, but it's too late to remove the update: many users have already updated, and if we remove it, and replace it later with a new update_2(), those users won't get that new update.

I added a CHANGELOG.txt for future use, and removed only the one line with the clear cache. The rest can't hurt anyway, and as I said, it's too late to remove it completely.

original issue:
http://drupal.org/node/145147

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.