Closed (fixed)
Project:
Notify
Version:
5.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Oct 2007 at 19:00 UTC
Updated:
30 Dec 2007 at 12:12 UTC
Jump to comment: Most recent file
In notify_update_2() the menu cache is cleared which is done using update.php anyway: http://api.drupal.org/api/function/update_do_updates/5
In my opinion notify_update_2() can be removed completely. The message in there should be part of the changelog only as it not a dynamic feedback of the update process.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | notify-update.patch | 764 bytes | Standart |
Comments
Comment #1
Standart commentedComment #2
beginner commentedOh I see. Good point, but it's too late to remove the update: many users have already updated, and if we remove it, and replace it later with a new update_2(), those users won't get that new update.
I added a CHANGELOG.txt for future use, and removed only the one line with the clear cache. The rest can't hurt anyway, and as I said, it's too late to remove it completely.
original issue:
http://drupal.org/node/145147
Comment #3
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.