Commerce Everyday

Hi,
Firstly there is lots of issue regarding line spaces, indentation & comments.

Look at this !
http://ventral.org/pareview/httpgitdrupalorgsandboxmitrpaka1866604git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

Manual Review:

1) There is no hook_uninstall to remove your custom variables from database like: commerce_everyday_method_title, commerce_everyday_method_title_icons, commerce_everyday_method_offsite_autoredirect, etc. in admin.inc

2) use variable_del() in hook_uninstall() that remove variables or delete sql query.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Reviews added

manual review:

1. "watchdog('commerce_everyday', 'Received callback for redirect validation with $_REQUEST:
   

   !request

   ', array('!request' => check_plain(print_r($_REQUEST, 1))), WATCHDOG_INFO);": use "@" placeholders instead of "!" then you don't need check_plain().

2. "$hash_elements[$element] = check_plain($_GET[$element]);": why do you run check_plain() on the varaibles if you are not printing them to the user? Please read http://drupal.org/node/28984 again. Same in "$hash != check_plain($_GET['OPR_RETURN_MAC'])".
3. commerce_everyday_redirect_form_validate(): before saving the order you should make sure that the incoming request is actually valid, no?
4. "$order = commerce_order_load($order->order_id)": why do you have to re-load the order? Please add a comment.
5. "date_default_timezone_set('Europe/Helsinki');": why is that location hard coded? Please add a comment.
6. _commerce_everyday_urlencode(): why is that necessary? Aren't those characters illegal in the path of a URL? Please add a comment.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

PAReview: Commerce tag added

Review link added

Did a manual review, looks RTBC to me now. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

no objections for more than a week, so ...

Thanks for your contribution, mitrpaka!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.