Comments

mikeytown2’s picture

Status: Active » Closed (won't fix)
StatusFileSize
new3.4 KB

Marking this as won't fix. Please re-open if you really need this. This is as far as I got with this patch.

Cyclodex’s picture

Is there still no https support in? Trying latest dev code but still having issues on my https site.
Is this only about proxy or also https website?
Trying to debug it...

mikeytown2’s picture

Status: Closed (won't fix) » Active

Re-opening this as there is now interest in https proxy support

Cyclodex’s picture

Assigned: Unassigned » Cyclodex

Hei, I had some success, migrated the patch to apply to latest dev version and could also find the issue why the URLS always were called with http instead of https.

I am not sure if this is only specific to our internal setup (proxy) or if others could have a similar issue...
My workaround was to add the following line to the Server vars check, because I did not have any of the checked variables set.
This of course because we have our own specific special setup here...

See the protossl addition in here:

function httprl_get_server_schema() {
  return (   (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on')
          || (isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https')
          || (isset($_SERVER['HTTP_HTTPS']) && $_SERVER['HTTP_HTTPS'] == 'on')
          // Adding protossl as we don't have the other vars set on our dev environment
          || (isset($_SERVER['protossl']) && $_SERVER['protossl'] == 's')
            ) ? 'https' : 'http';
}

I also had to change one line because this did not match to the latest code anymore, I will post you a patch which should apply to dev code soon...
if ($result->uri['scheme'] == 'proxy_https') {
instead of
if ($uri['scheme'] == 'proxy_https') {

Thanks for opening again , I will try to send you a patch soon where we can verify if all is fine...

Cyclodex’s picture

An other small detail, the first check of the HTTPS variable is also a bit wrong, our other development environment reports HTTPS = 1, which is of course fine, if you read the PHP doc:
http://php.net/manual/en/reserved.variables.server.php

'HTTPS'
Set to a non-empty value if the script was queried through the HTTPS protocol.
Note: Note that when using ISAPI with IIS, the value will be off if the request was not made through the HTTPS protocol.

So we also have to replace
return ( (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on')
with this line:
return ( (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off')

Its getting better and better :)

shane birley’s picture

Issue summary: View changes

How is this coming along? I have encrypted certain pages on a site and this appears to be an issue where I am returning blocked requests/denied requests from the web server.

socialnicheguru’s picture

is there a new patch? I'd love to test.

Background:
https://drupal.org/comment/6863806#comment-6863806

Here is a module,https://drupal.org/project/chr, that handles the issue instead of using the patch that this issue's patch was based on.

socialnicheguru’s picture

Status: Active » Closed (duplicate)

is this now a dupe of
https://drupal.org/node/2222555
I'll set it because it seems like it is, but please return it to whatever state you deem fit if it is not.

mikeytown2’s picture

Status: Closed (duplicate) » Active

Not a dup

kenorb’s picture

Status: Active » Needs review
socialnicheguru’s picture

Status: Needs review » Needs work

this no longer applies to 2/2016 dev version

kenorb’s picture

Assigned: Cyclodex » Unassigned