Needs work
Project:
HTTP Parallel Request & Threading Library
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2012 at 21:22 UTC
Updated:
27 Jun 2018 at 13:06 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mikeytown2 commentedMarking this as won't fix. Please re-open if you really need this. This is as far as I got with this patch.
Comment #2
Cyclodex commentedIs there still no https support in? Trying latest dev code but still having issues on my https site.
Is this only about proxy or also https website?
Trying to debug it...
Comment #3
mikeytown2 commentedRe-opening this as there is now interest in https proxy support
Comment #4
Cyclodex commentedHei, I had some success, migrated the patch to apply to latest dev version and could also find the issue why the URLS always were called with http instead of https.
I am not sure if this is only specific to our internal setup (proxy) or if others could have a similar issue...
My workaround was to add the following line to the Server vars check, because I did not have any of the checked variables set.
This of course because we have our own specific special setup here...
See the protossl addition in here:
I also had to change one line because this did not match to the latest code anymore, I will post you a patch which should apply to dev code soon...
if ($result->uri['scheme'] == 'proxy_https') {instead of
if ($uri['scheme'] == 'proxy_https') {Thanks for opening again , I will try to send you a patch soon where we can verify if all is fine...
Comment #5
Cyclodex commentedAn other small detail, the first check of the HTTPS variable is also a bit wrong, our other development environment reports HTTPS = 1, which is of course fine, if you read the PHP doc:
http://php.net/manual/en/reserved.variables.server.php
So we also have to replace
return ( (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on')with this line:
return ( (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off')Its getting better and better :)
Comment #6
shane birley commentedHow is this coming along? I have encrypted certain pages on a site and this appears to be an issue where I am returning blocked requests/denied requests from the web server.
Comment #7
socialnicheguru commentedis there a new patch? I'd love to test.
Background:
https://drupal.org/comment/6863806#comment-6863806
Here is a module,https://drupal.org/project/chr, that handles the issue instead of using the patch that this issue's patch was based on.
Comment #8
socialnicheguru commentedis this now a dupe of
https://drupal.org/node/2222555
I'll set it because it seems like it is, but please return it to whatever state you deem fit if it is not.
Comment #9
mikeytown2 commentedNot a dup
Comment #10
kenorb commentedComment #11
socialnicheguru commentedthis no longer applies to 2/2016 dev version
Comment #12
kenorb commented