Hi... i'm not sure if this is addressed somewhere in the docs...

When I installed the module for version 5 as per the docs, it broke my install: afterwards, Drupal kept telling me that the comments module was missing. As a result, many things, like Forums, stopped working...

I also got this error: "Cannot redeclare comment_help()" ... already defined in the comment.module....

It would seem that all the functions you declare in your module are already defined in the 5.3 comment.module.

Would renaming all the functions commentnotify_*() do the trick? I don't know enough PHP to know if that would do it....

But it is a very useful module.

Comments

Christoph C. Cemper’s picture

Christoph C. Cemper commented
Status: Active » Postponed (maintainer needs more info)

1. comment_notify hasn't been tested with DP 5.3 yet

2. BUT your comment_help issue indicates you messed up your installation, as all comment_notify functions are named function comment_notify_* anyway

please report your exact problem after sorting the comment thing,
errors from watchdog, etc.etc.

Lloyd Standish’s picture

Lloyd Standish commented

I am using comment_notify on 5.3. I believe the minor changes in 5.3 did not introduce any additional issues for comment_notify. It "works" on both Drupal versions.

However, on both 5.2 and 5.3 I get ugly error messages every time I "approve" a comment, as I reported (http://drupal.org/node/177658). Note that I incorrectly reported this as an "issue status update" rather than as a new issue (bug report), which it is.

curtbeckmann’s picture

curtbeckmann commented
Title: Comment Notify Breaks Drupal 5.3 » comment notify INSTALL.txt is unclear to newbies
Priority: Critical » Minor

First, I would like to say that Drupal is so easy to get familiar with, that I stopped reading all the install.txt files...unless I have a problem. I think the requirement that the comment.module needs replacement deserves an extra highlight, possibly in the admin/modules text ("Did you replace the comment.module as required in INSTALL.txt?")

But even if you do read INSTALL.txt... As a newbie, I read the Comment Notify install.txt, which instructs us to replace comment.module with comment.module.dp5.
* It does not say that dp5 module should be renamed to comment.module, and
* it does not say that the replace needs to be made in the /modules directory.

After some troubles, I realized that the instructions *probably* meant that the comment.module.dp5 need to be renamed, and that this new comment.module should replace the module in /modules (not in sites/all/modules/comment_notify)
Those experiments seemed to work better (until I installed 5.3...but that's a separate issue)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Whenever I see a message after installing that says "Did you read the INSTALL.txt" they always feel redundant and therefore annoying. Fortunately that problem is fixed in Drupal6 anyway.

I'm working to change the way that the comment.module.dp5 is provided in this issue and have added a note there about needing to update the INSTALL.txt and project page when that happens.

I also hope that having it in both the INSTALL.txt and on the Project page will help with this issue such that it won't be a problem that requires the install message.