Hello,
I'm using jquery_update to run jquery 1.8 in our themes and I've noticed that the date context plugin throws a jquery error on the context edit form:

Uncaught Error: Syntax error, unrecognized expression: #:input[name="conditions[plugins][date_context_date_condition][options][operation]"]

After some quick research, I stumbled across the use of the jquery selector ':input' to be deprecated as of jquery 1.7.

Looking at the date_context plugin code, it occurred to me that the use of ':input' as a '#dependency' selector is not standard. All other instances I could find using the ctools form helper '#dependecy' use the element id as the primary argument rather than a more generic input selector.

The included patch switches to this more standard use of '#dependency' and resolves the future-proofing issue with jquery.

CommentFileSizeAuthor
date-context-dependency.patch1.27 KBkaidjohnson

Comments

mist’s picture

Thank you :-)

podarok’s picture

Assigned: kaidjohnson » vijaycs85
Issue summary: View changes
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs manual testing

looks good for me
do we need additional manual testing for different versions here?
Marking RTBC

vijaycs85’s picture

Assigned: vijaycs85 » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed cc785f8 and pushed to 7.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.