Support Modal forms module [#1872630]

The following patch adds support of login process modified by Modal forms module.
Similar issues:
#832814: Incompatibility with Dialog API
#1061456: Incompatible with ctools modals/dialog api

--- legal.module.orig	2012-07-14 05:40:38.000000000 +0400
+++ legal.module	2012-12-22 15:10:38.000000000 +0400
@@ -420,6 +420,14 @@
     ->fetchAllAssoc('uid');
   $signatory = array_pop($result);
 
+  if ((arg(0) === 'modal_forms') && (arg(1) === 'ajax') && (arg(2) === 'login')) {
+    $dest = '';
+    if (isset($query['destination'])) {
+      $dest = '&destination=' . $query['destination'];
+    }
+    $_GET['destination'] = 'legal_accept/' . $signatory->uid . '/' . md5($signatory->name . $signatory->pass . $signatory->login) . $dest;
+    return;
+  }
   drupal_goto('legal_accept/' . $signatory->uid . '/' . md5($signatory->name . $signatory->pass . $signatory->login), array('query' => $query));
 }

Comment	File	Size	Author
#19	1872630-19.patch	734 bytes	rpayanm
#19	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#2	legal-support_modal_forms-1872630-2.patch	757 bytes	maximpodorov
#2
	legal-modal-forms.patch	713 bytes	maximpodorov

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

andypost

he/him

Russian

CreditAttribution: andypost commented 22 December 2012 at 11:52

Status:

Active

» Needs work

Please provide a patch in right format

File	Size
legal-support_modal_forms-1872630-2.patch	757 bytes

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost commented 24 December 2012 at 11:27

Status:

Needs work

» Reviewed & tested by the community

Great! very useful!

Comment #4

dercheffe

he/him

German

Sersheim, Germany

CreditAttribution: dercheffe commented 26 July 2013 at 14:21

I have the Issue this patch should fix (I don't know how to put in patches into my drupal installation, so I couldn't test the patch by myself). It would be great, if this patch could be taken in a normal release or in a dev-release. Thanks :)

Comment #5

richH CreditAttribution: richH commented 28 July 2014 at 20:53

Issue summary:

View changes

Hi,

did this patch ever make it into a release? I'm having this problem with Modal forms!

Cheers
Rich

Comment #6

zuernBernhard CreditAttribution: zuernBernhard commented 30 July 2014 at 19:55

Have the Problem here to. Would love to see this in stable release. Can I help somehow on this ?

Comment #7

zhinio CreditAttribution: zhinio commented 29 June 2015 at 14:52

I am having issues too. I would like to see the patch on a stable release too plz.

Comment #8

SocialNicheGuru CreditAttribution: SocialNicheGuru commented 23 June 2016 at 16:52

This patch no longer applies

Comment #9

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 23 June 2016 at 23:01

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs reroll

Comment #10

ashishdalvi

English

Mumbai

CreditAttribution: ashishdalvi at Blisstering Solutions commented 25 June 2016 at 02:14

Issue tags:

+DrupalMumbaiCodeSprint15

Good Novice issue for Drupal Mumbai Code sprint #15.

Comment #11

rasikap CreditAttribution: rasikap at Blisstering Solutions commented 25 June 2016 at 06:54

Assigned:

Unassigned

» rasikap

Comment #12

rasikap CreditAttribution: rasikap at Blisstering Solutions commented 25 June 2016 at 07:10

I could apply the patch, so no reroll is needed.

Comment #13

rasikap CreditAttribution: rasikap at Blisstering Solutions commented 25 June 2016 at 07:10

Status:

Needs work

» Needs review

Comment #14

rasikap CreditAttribution: rasikap at Blisstering Solutions commented 25 June 2016 at 08:44

Assigned:

rasikap

» Unassigned

Comment #15

ronsnow CreditAttribution: ronsnow commented 29 August 2016 at 15:36

Would be great (and appropriate) to have this patch committed to next release. Seems like a lot of time to span not to have incorporated into module.

Comment #16

abarpetia CreditAttribution: abarpetia commented 14 September 2016 at 00:34

Status:

Needs review

» Reviewed & tested by the community

Given patch in #2, works for me and I can apply it to dev branch so there is no need of reroll.

Comment #17

Robert Castelo CreditAttribution: Robert Castelo as a volunteer and at Code Positive Services commented 21 October 2017 at 21:26

Status:

Reviewed & tested by the community

» Needs work

I've added Lightbox2 support in the dev branch.

If anyone still wants modal forms integration take a look at how Lightbox2 is added in the admin form and in the label theme function and provide a patch.

https://www.drupal.org/node/372721#comment-12309650

Comment #18

dtamajon CreditAttribution: dtamajon commented 31 May 2018 at 08:40

@robert-castelo, I think the link you added is for opening Legal link in a popup, while this issue is about support Legal redirection while the login is openend in a popup with Modal Forms. To reproduce the problem, enable links for login on Modal Forms (with Legal already configured).

About patch #2, it stops working after latest Legal release. I have been trying to get it working with no success. Has anyone an updated patch for the latest Legal version?