Hi,

mpotter has discovered an issue where the navbar tpl file affects other elements of the theme's layout. Upon further investigation, he discovered that the opening tag is non-existent, and was replaced with a closing

tag. This was discovered in an installation of Panopoly using the Panelizer menu (at the bottom of the page).

Basically, the last closing tag in the tpl file should be replaced with a closing to resolve this issue.

CommentFileSizeAuthor
#1 navbar_has_mismatching_closing_tag_1875254_1.patch196 bytespcho

Comments

pcho’s picture

pcho commented
StatusFileSize
new navbar_has_mismatching_closing_tag_1875254_1.patch196 bytes

Patch here.

socialnicheguru’s picture

socialnicheguru commented
Status: Active » Needs review

changing so that others will know there is a patch solution here

cashwilliams’s picture

cashwilliams commented
Status: Needs review » Reviewed & tested by the community

Simple and tested

gcbound’s picture

gcbound commented

After the patch has been reviewed and tested by the community (current status), does it warrant a separate dev release of the module, or does that patch get rolled in with others? I'm curious about how the process works partly because I haven't maintained a module and partly because the fix makes some of our panels/Panopoly pages look much better :) And it's cool to be able to get the patched version from the "official" module URL.

hass’s picture

hass commented
Version: 7.x-1.0-alpha3 » 7.x-1.x-dev

Still not fixed in alpha4. How could it happen that a new release is created without fixing bugs?

jessebeach’s picture

jessebeach commented
Status: Reviewed & tested by the community » Closed (fixed)

Thanks pcho et. al.

Fixed in 7.x-1.x (04a1f67a5cebbf09f7dcc22d7cb20bf253fde796).

hass’s picture

hass commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.