Minor clean-up for Edit (more generic WYSIWYG editor integration facilities, prevent Drupal behaviors on "transport" forms) [#1875874]

Some comments were inconsistent with the rest of core comments.
Renamed the "wysiwyg-tabs" and "wysiwyg" toolgroups (in the per-field Edit toolbar) to "wysiwyg-floated" and "wysiwyg-main", so that it'd be more generally useful. The "tabs" stuff was only relevant for Aloha Editor. The difference between the two is: one of them is floated to the right (on LTR, to the left on RTL), to be next to the "Save" and "Close" buttons; the other one is full-width.
Added the ability to add an ID attribute to toolgroups.
I added ID attributes to both "wysiwyg" toolgroups by default. This is necessary for some WYSIWYG editors; we don't want random IDs to be attached, hence we want to provide this already.
I noticed when testing Edit + Editor (#1873500: CKEditor + Edit) that behaviors would get attached (in this case: text (WYSIWYG) editor attaching) even on the form that is hidden by Edit from the end user, that is solely used as a syncing/data transport mechanism. I added an override that will prevent that.

Comment	File	Size	Author
#3	1875874-2.patch	5.45 KB	frega
#3	interdiff.txt	2.55 KB	frega
#1	1875874-1.patch	6.2 KB	wim leers

Comments

Comment #1

wim leers

Ghent 🇧🇪🇪🇺

commented 28 December 2012 at 21:42

Status:

Active

» Needs review

Status	File	Size
new	1875874-1.patch	6.2 KB

Comment #2

wim leers

Ghent 🇧🇪🇪🇺

commented 2 January 2013 at 10:09

Issue tags:

+JavaScript

Comment #3

frega commented 2 January 2013 at 16:58

Status	File	Size
new	interdiff.txt	2.55 KB
new	1875874-2.patch	5.45 KB

Slightly reworked the patch from #1.

Using getters (prepend the internal "cleaned", DOM-compatible ID accordingly in getId, getFloatedWysiwygToolgroupId, and getMainWysiwygToolgroupId)
Renamed getFloatingWysiwygToolgroupId to getFloatedWysiwygToolgroupId (the function in the previous patch was never called and referred to an undefined _toolgroupWysiwygFloatingId property instead of _toolgroupWysiwygFloatedId)

Other than that, it looks to go I could be RTBC'd :)

Comment #4

wim leers

Ghent 🇧🇪🇪🇺

commented 2 January 2013 at 17:04

Thanks! The first makes sense, and the second is a good catch.

Comment #5

wim leers

Ghent 🇧🇪🇪🇺

commented 2 January 2013 at 20:42

Status:

Needs review

» Reviewed & tested by the community

On second thought, that's all the review we really needed :) After having discussed this with @frega: RTBC (assuming it comes back green — almost 4 hours later and still no test results :/).