Closed (fixed)
Project:
Openlayers
Version:
7.x-2.0-beta3
Component:
OL Behaviors
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
30 Dec 2012 at 18:14 UTC
Updated:
27 Sep 2013 at 17:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
gerontas commentedI can confirm this. After a point has been selected, it shows the correct 'select' style which remains after the pop-up is closed and the pop-up no longer works for that point. That condition remains until the map is reloaded.
I can't see anything that can be changed in the UI for this.
Comment #2
polFixed once for all !
http://drupalcode.org/project/openlayers.git/commit/6fb770c
Comment #3
gerontas commentedThat's looking good! Thanks Pol - much appreciated!
Comment #4
paularmand commentedI can confirm the patch works. It however also disables any behaviours attached to the contents of the popup (in my case ajax-links). I believe the "Drupal.attachBehaviors();" line was probably removed by accident. I can also confirm that by reenabling this line in the patched code, the behaviours are correct attached to the popup contents. Do we have to patch this, or can you edit the patch itself?
Comment #5
artbussy commentedThanks Pol & Paularmand, this works on my install. Have included but not tested Paularmand's remark. It doesn't throw any errors. As a non-coder implementing this is quiet a hassle. I guess a patch would be much appreciated by many dummies like me.
Comment #6
polComment #7
camhowardThanks for this! I ran into the same issue ifrik described. I applied Pol's patch in note #2 and paularmand's revision in note #4 and users can now select a popup as often as they wish. Thank you!
Comment #8
juliusvaart commentedI can confirm patch in #2 works.
Comment #9
spidermanI've just re-rolled this commit as a patch with the attachBehaviours() line still in, so those of us pulling modules in with drush make can use this:
Comment #10
polCommitted ;-)
Thanks for the help, Javascript is really not my cup of tea :-)
Comment #11
polComment #13
berliner commentedHi, the patches from #2 and #9 seem to be broken and the changes are not included in the beta3 release as far as I can see.
Comment #14
Georgique commented@berliner Changes will be included in the next beta.
And patches are ok. You can even apply them manually.
Comment #15
berliner commentedSerious? I got errors trying to patch the beta3 with the patches proposed here. I had to apply them manually, meaning by transferring the changed parts by hand ...
But, ok, as long as it's in the next release. I just had the impression that the fix had been lost. Sorry for the trouble.
Comment #16
gillesbailleux@berliner: just tested patch #9 and it works with OpenLayers 7.x-2.0-beta3 and Drupal 7.21
Comment #17
berliner commentedok, good to know :-) So it's been a problem on my side.
Comment #18
jcl324Has this been rolled into the dev branch yet?
Comment #19
pol#killmeplease
Comment #20
magtak commentedlike @ #9. I've been stuck at this for hours...
Comment #21
brahimmouhamou commentedI also had this problem, the patch works but I have a page with an openlayers map and an embeded vimeo video. Each time I open a pop up, the vimeo video flashes (becomes invisible for a millisecond). Very annoying.
Comment #22
xeeshangulzar commentedThank you so much Pol. You resolved my issue.
Comment #23
charlied commentedFor those who find patches scary, 7.x-2.0-beta7 fixed #1 for me - thanks !
Comment #24
nirad commentedI tried both #2 and #9, and neither works with javascript inside of the popup, despite the latter having the line
Drupal.attachBehaviors();. My particular use case is a toggle for the Flag module inside of the popup. If I click on the javascript flag link, the page refreshes.I had downgraded from beta7 to beta3 because of this problem. In beta 3, the javascript inside the popup works, but then the popup only works once and then disappears. After this patch, the javascript doesn't work. I believe these issues were not present in beta 1 and/or beta 2.
Comment #25
nirad commentedI opened a new issue to deal with the issue of ajax events not propagating in the popup since that is different issue than the popup only working once: https://drupal.org/node/2054215
Comment #26
spiderman