Download & Extend
Storm Project Management » Issues

Allow dashboard title to use string overrides

Posted by christopher.boss on January 3, 2013 at 7:37pm
Project:Storm Project Management
Version:6.x-2.x-dev
Component:Storm.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hello All,

I saw some other discussions (http://drupal.org/node/744694, http://groups.drupal.org/node/112924) regarding using the String Overrides module to rename the Storm dashboard. I have successfully renamed Storm in some areas (like the Primary Links) using String Override module, but I cannot seem to override the title of the Storm dashboard itself, or the breadcrumb. I am still new to Drupal, so it is likely I may be missing something with the way overrides work.

I can rename Storm the 'wrong' way, i.e.:

function storm_storm_dashboard_types() {
  return array(
    'page' => array(
      'url'         => 'storm',
      'title'       => 'TAR dashboard',

(title is set to TAR instead of Storm)

But, this is just a bad habit to customize module code! Is there a way to rename Storm dashboard using String Override module?

Just FYI, I have tried this in settings.php:

$conf['locale_custom_strings_en'] = array(
   'Storm dashboard' => 'TAR dashboard',
);

With no luck.

Thanks so much for any help you can give!

Login or register to post comments

Comments

#1

Posted by juliangb on January 3, 2013 at 9:00pm
Status:active» needs review

You should be able to do the string overrides, and I think it is a bug if you can't.

Can you try this patch? (And then your overrides)

AttachmentSizeStatusTest resultOperations
storm-dashboard-string-overrides.patch1.31 KBIdleFAILED: [[SimpleTest]]: [MySQL] 2,423 pass(es), 203 fail(s), and 622 exception(s).View details

#2

Posted by System Message on January 3, 2013 at 9:26pm
Status:needs review» needs work

The last submitted patch, storm-dashboard-string-overrides.patch, failed testing.

#3

Posted by christopher.boss on January 3, 2013 at 11:02pm
Status:needs work» fixed

Hello Julian,

Wow, I appreciate your quick response!

The patch did resolve my issue with String Overrides module.

Looks like everything is working now.

Thank you so much!

#4

Posted by juliangb on January 4, 2013 at 9:31am
Version:6.x-2.1» 6.x-2.x-dev
Category:support request» bug report
Status:fixed» needs review

Thanks for the feedback.

Just before we close this issue - I'll make sure that the automated tests pass, and we'll commit this so that it appears by default in the next download.

#5

Posted by juliangb on January 4, 2013 at 9:32am

#1: storm-dashboard-string-overrides.patch queued for re-testing.

#6

Posted by juliangb on January 4, 2013 at 9:32am
Title:Can I String Override instead of hacking the code?» Allow dashboard title to use string overrides

#7

Posted by System Message on January 4, 2013 at 9:35am
Status:needs review» needs work

The last submitted patch, storm-dashboard-string-overrides.patch, failed testing.

#8

Posted by juliangb on January 16, 2013 at 8:58pm
Version:6.x-2.x-dev» 7.x-1.x-dev
Status:needs work» needs review

Let's try this for 7.x.

AttachmentSizeStatusTest resultOperations
storm-translation.patch1.61 KBIdlePASSED: [[SimpleTest]]: [MySQL] 326 pass(es).View details

#9

Posted by Francewhoa on January 17, 2013 at 5:55am
Status:needs review» reviewed & tested by the community

juliangb, confirming this works. Thanks :) This is useful.

Using
* stringoverrides 7.x-1.8
* Fresh Drupal 7.18
* Storm 7.x-1.x-dev 2012-Dec-24
* Views 7.x-3.5
* CTool 7.x-1.2

AttachmentSizeStatusTest resultOperations
before.png46.1 KBIgnored: Check issue status.NoneNone
after.png48.8 KBIgnored: Check issue status.NoneNone
conf.png45.99 KBIgnored: Check issue status.NoneNone

#10

Posted by juliangb on January 17, 2013 at 8:40am
Version:7.x-1.x-dev» 6.x-2.x-dev
Status:reviewed & tested by the community» needs work

Thanks for testing @Francewhoa. Committed and pushed in to 7.x-1.x.

Moving this back to 6.x-2.x, where I think the patch works, but it seems that the 6.x-2.x tests aren't passing at the moment. This will need some work to fix before we can commit other patches.

#11

Posted by juliangb on February 9, 2013 at 4:36pm
Status:needs work» fixed

Committed this to 6.x-2.x.

#12

Posted by System Message on February 23, 2013 at 4:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here