tableselect.js performances [#1880798]

what's wrong ?

So … tableselect.js really is the cause of all this slowness. Apply the attached patch and be delighted. You might even put away that knife that you wanted to use to stab your eyes out. (OTOH, with this patch applied, if you want to run *all* tests, now you'll want to use the aforementioned knife to check the zillion checkboxes on your screen.)

see: http://drupal.org/node/1751418#comment-6902852

Patch:
use native way to boost the perofmrnace.
http://api.jquery.com/category/selectors/jquery-selector-extensions/

Comment	File	Size	Author
	tableselect_perforamnce_fix.patch	2.51 KB	droplet

Comments

Comment #1

wim leers

Ghent 🇧🇪🇪🇺

commented 5 January 2013 at 09:23

Can you create a benchmark on jsperf.com? Intuitively, I doubt this will make a big difference?

Comment #2

droplet commented 5 January 2013 at 10:43

http://jsperf.com/jquery-ext-vs-dom

Comment #3

droplet commented 5 January 2013 at 10:55

check out this version if you looking for more real world (drupal test) result: http://jsperf.com/jquery-ext-vs-dom/2

Comment #4

kscheirer

English

Vallejo

commented 7 January 2013 at 07:36

Thanks for the benchmarks! http://jsperf.com/jquery-ext-vs-dom/2 seems to indicate that using the .filter() method would be faster across all browsers. IE and Firefox like that better, and Chrome is about the same whether you use filter or native dom method. Any way to get Safari in on that jsperf test?

Whichever method ends up getting used, is it worth fixing in other *.js files we include with drupal core? Or is tableselect the only one where this is enough of a performance benefit to merit a patch?