After running the 7.x-1.1+2-dev (2012-Dec-25) version for about 10 days I still have only three backups in my list. Prune keeps deleting the fourth one every day.

Right now I have backups for Thursday 3rd, Friday 4th, and Saturday 5th.
However, there's still the .gz.info file for Tuesday, January 1st!

Every day I see the following:
on 3pm B&M creates a new backup
on 4pm Prune deletes a .gz file (says "Deleted 1 backups.")
on 5pm Prune deletes a .gz.info file (says "Deleted 1 backups." again)

12/30: 2012-12-28.mysql.gz, 2012-12-28.mysql.gz.info
12/31: 2012-12-29.mysql.gz, 2012-12-29.mysql.gz.info
01/01: 2012-12-30.mysql.gz, 2012-12-22.mysql.gz.info
01/02: 2012-12-31.mysql.gz, 2012-12-30.mysql.gz.info
01/03: 2012-12-27.mysql.gz, 2012-12-27.mysql.gz.info
01/04: 2013-01-01.mysql.gz, 2012-12-31.mysql.gz.info
01/05: 2013-01-02.mysql.gz, 2013-01-02.mysql.gz.info

This leaves me with the following files:
2013-01-01.mysql.gz.info
2013-01-03.mysql.gz
2013-01-03.mysql.gz.info
2013-01-04.mysql.gz
2013-01-04.mysql.gz.info
2013-01-05.mysql.gz
2013-01-05.mysql.gz.info

Having deleted a matching pair of files today, I'm now manually deleting the odd 2013-01-01.mysql.gz.info file and will keep watching how this develops further...

Comments

e0ipso’s picture

I had just detected this bug. And should be fixed now on -dev.

The problem was that this weeks backups were not treated as an special case were you need to keep the most recent backup for EVERY day and not one day.

I created a mockup filesystem to test it. More on that on http://drupal.org/node/1872428

salvis’s picture

StatusFileSize
new13.38 KB

I've been running that snapshot for a week now, set to keep the Sunday backup, and today Prune decided to delete Thursday's backup. I'm now left with the following backups:

prune_thursday.png

This comes as a surprise. I would have expected Prune to delete the Monday tomorrow, Tuesday the day after tomorrow, etc., and keep the Thursday until next Thursday.

Also, as before, Prune deleted the .gz file, but it left the .gz.info file behind.

salvis’s picture

Version: 7.x-1.x-dev » 7.x-2.0-beta1
StatusFileSize
new6.76 KB

Here's a current snapshot:

prune_1m.png

Month and week look ok, but where did Thursday and Friday go?

Today, Prune deleted
1/20,
2/11, and
2/14 (Thursday!)

krystalcode’s picture

The time of the file in the Gardener seems to be in ISO format while it is used as a unix timestamp. That throws a warning and it messes up calculating which files should be deleted and which not.

The attached patch fixed that. I will test behavior in an actual site over a period of time and see if that fixes the issue.

krystalcode’s picture

Updated patch with missing code.