Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Jan 2013 at 09:51 UTC
Updated:
19 Feb 2013 at 14:58 UTC
This installation profile has been created for Drupal Turkish Society. Its URL is http://drupal.org/sandbox/GANYANCI/1875594
Comments
Comment #1
abhijeetkalsi commentedHi,
first of all there are quite a few issues to sort out such as indentation, whitespace.
You can find them all here:
http://ventral.org/pareview/httpgitdrupalorgsandboxganyanci1875594git
Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.
Also change your status to
need review
if you want the other reviewer will review your module.
Comment #2
kartagisComment #3
sadashiv commentedI think you should participate in review bonus program
also provide more info like the git clone url, more description, etc specified at http://drupal.org/node/1011698
Comment #4
jgalletta commentedHi,
Your git repository has a master branch, you should delete it: Moving from a master branch to a version branch.
Manual review:
As your repository contains an entire Drupal site, I just looked at the basic drupal profile files, i.e. drupalturkiye.install and drupalturkiye.profile.
-Many of your comments do not respect the Drupal Coding Standards (http://drupal.org/node/1354)
-You have some code formatting errors (space missing after colon, ...), install and run Coder module on your code.
-Your hook_install is 274 lines long, it's too big, try to split it into several functions.
-l283:
I think you should let the user know what is going on exactly.
-Some of your comments do not respect the Drupal Coding Standards (http://drupal.org/node/1354)
-You have some code formatting errors (space missing after colon, ...), install and run Coder module on your code.
Comment #5
bhosmer commentedIf you're interested in continuing the application process, what is the status with the issues raised in #4?
You might also want to review [How to Create an Install Profile](http://drupal.org/node/1022020)
Comment #6
Sahin commentedIt seems like this project has moved to http://drupal.org/project/tr_kurulum and this application is now obsolete.