"Google OAuth2" is a module which allows you to authenticate with google and use this authentication to carry other api requests. This can help you to manage accounts, authenticate with google (i.e. get access token, oauth2 token) and use this authentication to carry api requests in other modules. This module allows you to enter google account details like client id, client secret key, developer key, select google services to be enabled and gets the OAuth2 access token from google. The account manage page also shows a authenticate link if the account is not authenticated (this can be helpful to authenticate later if the account is created by google_oauth2_account_save) and shows a Revoke link if the account is already authenticated and you want to revoke access.

Project page: http://drupal.org/sandbox/sadashiv/1857254
Git clone: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/sadashiv/1857254.git google_oauth2
Drupal version: 7.x,
Dependencies are: Libraries API

Reviews of other projects:
http://drupal.org/node/1880994#comment-6907378
http://drupal.org/node/1826640#comment-6907462
http://drupal.org/node/1865018#comment-6907494

Comments

abhijeetkalsi’s picture

abhijeetkalsi commented

Hi

first of all there are quite a few issues to sort out such as indentation, whitespace.

You can find them all here:
http://ventral.org/pareview/httpgitdrupalorgsandboxsadashiv1857254git

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs review » Needs work
sadashiv’s picture

sadashiv commented
Status: Needs work » Needs review

Thank you for your feedback.

I have fixed the issues in
49c95e8 and fb010e5 : Fixed errors and warning shown by automatic review.

Thanks,
Sadashiv.

vladimir-m’s picture

vladimir-m commented
Status: Needs review » Needs work

Hello sadashiv,

Thank you for great module.

I would recommend to wrap in t() message from: google_oauth2.admin.inc Line: 140

form_set_error('name', 'Name already in use. Please choose a unique name for the account');

Also will be grate before to encode special characters in a plain-text - check_plain().

Cheers!

sadashiv’s picture

sadashiv commented
Status: Needs work » Needs review

Thanks for your feedback.

I have fixed the form_set_error in 63f952d

sadashiv’s picture

sadashiv commented

Reviewed more projects at
http://drupal.org/node/1883898#comment-6931820
http://drupal.org/node/1881934#comment-6931858

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Don't forget to add the "PAReview: review bonus" tag as indicated in #1410826: [META] Review bonus, otherwise you won't show up on my high priority list.

sadashiv’s picture

sadashiv commented
Issue tags: +PAreview: review bonus

Thanks for updating me.

Adding "PAReview: review bonus" tag.

Reviewed http://drupal.org/node/1711932#comment-6932326

rickumali’s picture

rickumali commented

Hello @sadashiv,

I started to look at this module. My initial feedback is that I was able to install the module without having installed the Google PHP Client Library in sites/all/libraries. I did get an error when I tried to save an API key ("Can't authenticate with google as library is missing check Status report or Readme for requirements").

I don't know if this is a standard practice, but when you implement hook_requirements() in google_oauth2.install, maybe you should check during $phase=="install" whether the "google-api-php-client" library can be loaded.

Hopefully I'll have more feedback as I work through the module. Good luck!

sadashiv’s picture

sadashiv commented

Hi @rickumali,

I think phase install should be checked if we want the library during installation. My module don't need the library during installation but needs it while authenticating so I checked phase is runtime. I referred few modules for this.

Correct me if I am wrong and should keep phase runtime and install.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

http://drupal.org/project/gauth

This sounds like a feature that should live in the existing gauth project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the gauth issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

sadashiv’s picture

sadashiv commented

Thanks @klausi
I have created a issue on gauth for adding me as maintainer.

I thought the modules are slightly different so I created a new project and also found one request asking for this module at http://drupal.org/node/1848768.

rickumali’s picture

rickumali commented

Hi @sadashiv,

Regarding our "phase==install" discussion (comments #9 and #10), I do like your interpretation (the module doesn't need the library during installation, therefore no check is done at that phase). Please keep the code as is for now!

PA robot’s picture

PA robot commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.