Hey there,

I'm working on getting Subscriptions into a SOLR Facet today so I've created this Issue to post a patch should I get this to work.

CommentFileSizeAuthor
#6 simplenews-simplenews_subscriptions_in_solr-1886022-6.patch1.31 KByanniboi
#4 simplenews-simplenews_subscriptions_in_solr-1886022-4.patch1011 bytesyanniboi
#1 simplenews-simplenews_subscriptions_in_solr-1886022-1.patch1.08 KByanniboi

Comments

yanniboi’s picture

yanniboi commented
Status: Active » Needs review
StatusFileSize
new simplenews-simplenews_subscriptions_in_solr-1886022-1.patch1.08 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Huh, that is interesting ;) I like it when standardizing on entities allows to do cool stuff like this.

However, I think that this should be using the normal info() hook, not alter, as we define new properties for our own entity type, not alter something. And the new way of doing this is the metadata controller, which we already define, so you should be able to just stuff this into SimplenewsSubscriberMetadataController.

yanniboi’s picture

yanniboi commented

You have no idea how much easier 2.x-1.x makes our lives! Rules integration for VBO, SOLR facets. I have the day off today because you make it so easy :) (So what better way to spend a day off than to contribute to the community)

yanniboi’s picture

yanniboi commented
Status: Needs work » Needs review
StatusFileSize
new simplenews-simplenews_subscriptions_in_solr-1886022-4.patch1011 bytes

I've taken your advice and moved it to the Metadata Controller. Any other improvements just let me know.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Hm, not quite sure but I think we want to keep the callback in the .module. I don't think the .info.inc file is always loaded, probably just when this properties are rebuilt?

yanniboi’s picture

yanniboi commented
StatusFileSize
new simplenews-simplenews_subscriptions_in_solr-1886022-6.patch1.31 KB

Makes sense!

Status: Needs review » Needs work

The last submitted patch, simplenews-simplenews_subscriptions_in_solr-1886022-6.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#6: simplenews-simplenews_subscriptions_in_solr-1886022-6.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.