This module adds a JavaScript snippet that loads the tracking script, in a non-blocking manner, from Bizible. This module begins working when it's enabled. No additional configuration necessary. The site's owner or agent reviews the analytics from the Bizible website.

5.x-8.x
Since this is a tracking and analytics module, we've written a version for Drupal 5-8. Even though Drupal 5 is now end of life, it was added just in case an existing site would like to use our service.

Project Page:
http://drupal.org/sandbox/Bizible/1885902

Repository Page:
http://drupalcode.org/sandbox/Bizible/1885902.git

All branches are similarly named, switch the 7 with 5-8.
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/Bizible/1885902.git bizible_analytics

Regarding checklist item "2.3 Ensure your project contains a minimum of handwritten code.":
I understand the "Create Full Projects" role won't likely be granted.

Reviews:

http://drupal.org/node/1894210#comment-6973748
http://drupal.org/node/1900094#comment-6989440
http://drupal.org/node/1702136#comment-6989192

Comments

Bizible’s picture

Bizible CreditAttribution: Bizible commented
Status: Needs work » Needs review

Changing to needs review

vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented

Hi,

There feww error regaring spaces & comment, Please check it out.
http://ventral.org/pareview/httpgitdrupalorgsandboxbizible1885902git

Manual review :

1) Also rename your function ' _bizl()' to your module name bizible_analytics_bizl().
2) Use l() function to create your link in line no : 18 in hook_help()

udaksh’s picture

udaksh CreditAttribution: udaksh commented
Status: Needs work » Needs review

Hi Bizible,

Manual review:
Instead of writing all javascript inside drupal_add_js(). I would say to make a seperate .js file and then add this file in drupal_add_js().

Changing the status to needs work.

Thanks,
Udaksh.

udaksh’s picture

udaksh CreditAttribution: udaksh commented
Status: Needs review » Needs work
vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented
Status: Needs review » Postponed (maintainer needs more info)

Your module is very small, just 48 lines of code.

How much code do we need to approve a user?

Drupal administrator proposed two simple rules that can be used to deny the "create full projects" permission, as a general guideline.

* The project has less than five function or class method definitions
* The PHP/JavaScript source code is less than 120 lines long (including comments and white space.

Feel free to change status to Need review, after resolving all issues.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Postponed (maintainer needs more info) » Needs work

@osscube: of course we also approve small projects, we just can't give the git vetted user role away on them.

Bizible’s picture

Bizible CreditAttribution: Bizible commented

Thanks for the quick responses.

Resolved Issues for the 7.x branch.
Now the only message from pareview is a false error that I'm guess is catching the 2nd // from the URL in the comment.
http://ventral.org/pareview/httpgitdrupalorgsandboxbizible1885902git-7x-1x

Re #2:
I didn't rename the function because the original error is a php check, and it's a JavaScript function. Also the function is safe enough not to conflict with any other functions, and named well enough to determine it's origin, especially in it's own .js file.

I didn't use the l() function in the hook_help, but did update to reflect what the l() documentation says. According to the l() documentation:

http://api.drupal.org/api/drupal/includes!common.inc/function/l/7
However, for links enclosed in translatable text you should use t() and embed the HTML anchor tag directly in the translated string. For example:
t('Visit the <a href="@url">settings</a> page', array('@url' => url('admin')));
This keeps the context of the link title ('settings' in the example) for translators.

I didn't run the URL through l() or url() because as a static external link it doesn't need to be made safe from user input, or need an 'active' class attribute.

#3 Done.

Bizible’s picture

Bizible CreditAttribution: Bizible commented
Status: Needs work » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Bizible’s picture

Bizible CreditAttribution: Bizible commented
Issue tags: +PAreview: review bonus

The only PAReview issue is the JavaScript function.

Instead of having a separate server hit for a small js file, I put the code back into PHP, and used a heredoc for readability.

I'm still not sure of the t() in hook_help. AFAIK there's no reason to run the URL through l() or url() because it's external. Since it's not being generated from variables, it doesn't need to be made safe. The link text is a proper noun, which isn't translatable, but not sure if removing it will hinder translating it.

Reviews:
http://drupal.org/node/1894210#comment-6973748
http://drupal.org/node/1900094#comment-6989440
http://drupal.org/node/1702136#comment-6989192

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus +PAreview: single application approval

Thank you for your reviews, please add them to the issue summary so that we can better track them. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

  1. project page is too short and does not say anything about what the module does. See http://drupal.org/node/997024

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, Bizible!

I have promoted this project for you: http://drupal.org/project/bizible_analytics

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Bizible’s picture

Bizible CreditAttribution: Bizible commented

Thank you Klausi!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Adding Reviews