Comments

specky_rum’s picture

Anyone got any news on this?

generalredneck’s picture

Version: 7.x-2.0-alpha7 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new920 bytes

This is still an issue. It seems that the events are never fired anywhere in feeds. I've got a patch but it needs testing. I'm not 100% sure that the conditions used in conjunction with the event work correctly. If you need a specific version of feeds fixed, you should be able to reroll this patch fairly easily.

Status: Needs review » Needs work

The last submitted patch, feeds-making_rules_events_fire-1886230-2.patch, failed testing.

generalredneck’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, feeds-making_rules_events_fire-1886230-2.patch, failed testing.

zephirus’s picture

Any news about this issue? I really need to perform some actions on "After importing feed" rule.

generalredneck’s picture

I know for a fact this works because I'm using it on a production site right now... I just need to get it stable so that it pasts tests. With that said, Use at your own risk.

I'll see what I can do about the tests this morning.

generalredneck’s picture

Status: Needs work » Needs review
StatusFileSize
new1.37 KB

This should fix the problems. It looks like the tests weren't enabling the rules module. This did bring out the fact that I don't check to see if one had the rules module. Not having the rules module enabled proved to be fatal... as I am now posting this patch after seeing the white light of a WSOD. It wasn't pure though... as it had a twinge of black that said something about rules_invoke_event wasn't found.

Take it away testbot!

Status: Needs review » Needs work

The last submitted patch, feeds-making_rules_events_fire-1886230-8.patch, failed testing.

generalredneck’s picture

ok the failing tests make no sense to me... anyone want to help on that reguard? It's all stuff I haven't even bothered to touch. I can assure you though that the changes do work and seem to be stable from my testing...

benchesters’s picture

Is there any more news on this, I need this rule to fire! Thanks.

dexiecarla’s picture

Subscribing

zuernbernhard’s picture

These hooks / rules implementations don't fire in cron but when you start the feeds-imnport manually from backend with file_upload-fetcher. there is no module_invoke_all or rule_invoke_all in case of cron usage !

werfu’s picture

Issue summary: View changes

I have the same issue, I had this event working and suddenly something caused it to not work anymore. I've digged through the feeds.rules.inc and seen how the feeds_rules_event_info generate the handler for each Feeds importer. However, does somebody know where the rules_invoke_event for these handler get called?

glynnr’s picture

There is no rules_invoke_event for this event, which makes it ineffective.

My workaround is to implement hook_feeds_after_import and then invoke it myself.

function my_module_feeds_after_import(FeedsSource $source) {
  rules_invoke_event('feeds_after_import', $source);
}
jelo’s picture

Any progress on this? Would be great to have it functioning again by adding the proper call to fire the rule off. In the meantime glynnr's workaround did it for me...

megachriz’s picture

Status: Needs work » Needs review
StatusFileSize
new1 KB

Apparently, you need to install the Feeds Rules module for the invoking event to have effect. The code was added in #1744570: Invoke Before import event before start import (I found this out by executing git blame feeds.rules.inc). I believe there happened some miscommunication in that issue.

The attached patch is a sort of reroll of #8 without adding a dependency on Rules in the automated tests. The tests in #8 failed because the testbot didn't know it needed to checkout the Rules module (you can only tell the testbot this by committing a dependencies[] entry or a test_dependencies[] entry to the module's .info file).

ConradFlashback’s picture

Sub

  • MegaChriz committed 078346c on 7.x-2.x
    by MegaChriz: add rules as a test dependency for issue #1886230.
    
megachriz’s picture

Now with an automated test. And also a reroll, because the patch in #17 no longer applies.

The test only patch should fail.

The last submitted patch, 20: feeds-making-rules-events-fire-1886230-19-test-only.patch, failed testing.

megachriz’s picture

The last submitted patch, 22: feeds-making-rules-events-fire-1886230-22-test-only.patch, failed testing.

  • MegaChriz committed da83212 on 7.x-2.x
    Issue #1886230 by MegaChriz, generalredneck: fixed invoking rules events...
megachriz’s picture

Status: Needs review » Fixed

Committed #22.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.