Problem/Motivation
Exception: Empty configuration identifier. in FeedsConfigurable::instance() (line 55 of feeds/includes/FeedsConfigurable.inc).
Steps to reproduce:
Fail:
/ca/import/
Works:
/ca/import
Proposed resolution
Exit early on the menu object loading if the $id is empty.
Remaining tasks
User interface changes
n/a
API changes
Original report by @giorgio79
I started getting this message when accessing admin/structure/feeds/tamper/list/
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | exception_empty-1887632-7.patch | 332 bytes | joelpittet |
Comments
Comment #1
hvalentim commented+1
Works fine you use latest dev versions from both Feeds and Feeds Tamper.
Comment #2
mjbirdge commentedI have the same error message, when I try to access /admin/structure/feeds/:
Exception: Empty configuration identifier. in FeedsConfigurable::instance() (line 55 of sites/all/modules/feeds/includes/FeedsConfigurable.inc).
Not sure if this is a Feeds or Feeds Tamper issue, but noticed this post.
I have tried this with both of the following configurations with the same error:
I was able to temporarily work around this error message by going into the FeedsConfigurable.inc, and commenting out the line causing the code to throw an exception:
Comment #3
twistor commentedI would have to guess that you deleted an importer that feeds tamper missed.
Comment #4
twistor commented@mjbirdge, Can you give me some more information about your setup? Specifically, what importers exist, and which of them are enabled/disabled?
Comment #5
jet-lagger commentedI have the same problem with both version configurations
Comment #6
twistor commentedComment #7
joelpittetI'm getting this too, I've got a multilingual site but I don't think that matters much.
Fail:
/ca/import/
Works
/ca/import
This patch seems to do the trick
Comment #9
joelpittetFailed because it was a feeds issue. Moving this over there.
Comment #12
joelpittet*squints* at testbot...
Comment #15
joelpittetWhoops wrong branch, no wonder.
Comment #16
joelpittetComment #19
twistor commentedI couldn't reproduce the bug, but I believe you.
I changed the patch a bit, it's better to have all of the id validation logic in one place.
Also,
empty()isn't safe to use since 0 (zero) is technically a valid importer id :/.Comment #20
joelpittet@twistor Awesome that fixed it too:)
I wasn't sure if 0 was a valid value either, normally for me it's not:)