Sur.ly

Hi,

Looks interesting :)

I have a few comments:

-You should use libraries API to handle the libraries you use in the module. I have a sandbox module you can use as an example http://drupal.org/node/1880994 it's Drupal 7 though. I'm not sure for Drupal 6 but I guess it works kinda the same way.
-Function drupal_add_js shouldn't be called from template files.
-Looking through your module file there's some code style issues, I guess you can more using PAReview.
-I'm not sure if the class DrupalSurly belongs in the module file.

Cheers,

Troels

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Surdotly,

When I enabled this module, I got fatal error. Could you please look into this.

I understand,It requires the surly library.But it should be an user friendly message like how the print module is working.

PFA.

Regards,
-Raj.

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxsurdotly1872684git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

You have a number of problems that should be fixed before this is RTBC:

First off, this seems best implemented as an input filter. This is Drupal's built-in mechanism for altering content before displaying it to the user, read this handbook page for more information: https://drupal.org/node/213156.

Bare PHP is not allowed in Drupal in most cases. This code belongs in a hook_requirements() call. Left the way it is, it will be executed for every Drupal page load.

if (!_surly_try_load_classes()) {
  $t = get_t();
  drupal_set_message(
    $t(check_plain("Please, download !link and extract it to 'sites/all/libraries/surly-sdk'. Sur.ly plugin will not work without Sur.ly SDK."),
       array('!link' => l($t('Sur.ly SDK'), 'http://sur.ly/surly-sdk.zip'))
    ),
    'warning'
  );
}

In surly_menu() you are exposing all your user ids to the public by leaving the access callback as just TRUE. I also don't see where you're making use of this function.

    'surly/getid/%' => array(
      'page callback' => 'surly_get_id',
      'page arguments' => array(2),
      'access callback' => TRUE,
      'type' => MENU_CALLBACK,
      ),
    );

I'm not sure what all is going on in surly_config.tpl.php, but that looks mighty complicated and at least some of that should be in a theme function instead.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.