ifac follow-up: easy way to get to end of issue

It would also help to collapse the 'File attachements' and 'Edit issue settings' by default. I guess you could see the last post above the comment form then already. Otherwise I agree that #2 is the nicer approach. I like keyboard 'shortcuts' better than a link to click ;)

It would also help to collapse the 'File attachements' and 'Edit issue settings' by default.

we explicitly open these be default -- this is not going to change.

attached patch adds the links in an unordered list, for last followup, last attachment, and comment form. tested the functionality thoroughly, and it works well. what we need now is a themer to clean up the appearance/layout a bit. specifically:

• get rid of the list bullets
• arrange the layout so that the metadata table and the links are in the same vertical space, with the metadata table left, and the links right (floating, i guess)

Okay, It now uses theme_links so it uses existing styles to keep them horizontal. And they are floated to push the tables and links to the opposing sides. But I can see a potential issue when the table or the list of links become too wide. It'll clear the float in that case but that may not be a big deal.

A little misunderstanding made me redo the links horizontally. This simply bring it back but still uses theme_links. The benefit is that we have more classes with the function.

attached cleans up a bit of dead code, and also removed the 'Add new comment' link from the issue -- it's redundant now.

running into some weirdness w/ theme overrides using theme_links, so switching to theme_item_list, which works better across themes in this case.

i tweaked the functionality of the custom comment form location hack we have to better support this feature. now the custom form location is only activated if the right conf variable is set in settings.php, which makes things a lot cleaner, whether you're using the hack or not.

1 -- fixed
3 -- added
2 -- we had problems with the bluebeach theme and theme('links'), it wasn't allowing us to theme the links vertically. i'd be happy to change back to theme('links') if somebody could figure out what's going on there...

applied to HEAD, installed on drupal.org. i even used the post link to get to the comment box... :)

Cool. I'm happy for the change (but was completely unavailable all day on Saturday, so I didn't see any of this). Now we just have to fix the UI. ;) IMHO, the links are visually terrible, even though functionally useful:

A) (As hunmonk pointed out): They have to float to the right of the metadata table so-as not to waste precious above-the-fold real-estate for (*gasp*) content when looking at an issue. This is *not* a bluebeach problem. project_issue.css should fix this.

B) WTF are these links bold for? ;) Sure, it's a new feature, but they attract *WAY* too much attention to themselves.

C) They're links. Why don't they look like links? (i.e. in bluebeach, why aren't they blue)?

D) "followup" isn't a word. In fact, I thought one of the points of IFAC was to get rid of the "F" from the UI entirely. They're not special, they're just comments. Why can't this just be the "Add new comment" link for some consistency with the rest of the Drupal UI, even if it's in a slightly different place?

Also, didn't test this at all and have no time to look closely now, but...

E) What happens if a site configures things so that the comment form is displayed on a separate page? We still need to support that configuration.

Thanks to everyone involved. I agree the new links can help usability, once they're not so visually distracting.

a, b, and c: clear your browser cache, none of these are really problems
e: already accounted for

d: i'm happy with the current wording, but if we arrive at a consensus to change it a bit, that's fine.

According to http://www.answers.com/followup&r=67 follow-up is a word, but for the sake of consistency and possibly translatability, I'd be fine going to comment.

The whole 'head section' of issue pages doesnt look good. Both the status box on the left and the 'Jump to' stuff on the right look as if they were designed in a hurry. And they dont fit together nicely IMO. Cant we get this arranged a bit nicer? How about a table (maybe with the layout similar to the 'Edit issue settings' section) that distributes the status items and links in 2-3 rows. I dont have time to make a patch today, but attached is a very simple draft of how it might look like. I think this would also accent the status items a bit more.

@profix898. #15 is out of scope for this issue. please file another issue if you'd like to address this.

aclight and i tested, and c) is actually still a problem (although not currently on d.o, b/c bluebeach is hacked). it's out of my CSS league, so hopefully somebody can step up w/ a real fix on that one

Actually, I'm not sure if it's really possible to fix c) in an elegant way. The problem comes from the fact that when l() is called, it adds the "active" class to any link that's directed at the same page the user is currently on. I think this is designed for links in the menu, where this is desired behavior. However, since these links also point to the same page, they get the "active" class.

I'm sure we could override this in project_issue.css, but we'd have to specify a color for active links, and we don't have any way of knowing what color is used for regular links on the site.

The only way I can think of to get around this is to either:
1) remove the active class after theme_item_list() is called, or
2) create links on our own in project_issue_internal_links() instead of calling l().

I don't know that either of these approaches is a good idea.

Maybe we could just put a comment in the code or maybe in UPGRADE.txt pointing out why this happens and suggesting that users override li a.active in their style.css files on their sites.

@hunmonk: Slick, thanks. ;) Sorry about that -- I didn't think to clear my cache since I saw no mention of any of those fixes.

@profix: I agree the visual appearance still needs some help (and integration), but I also agree with hunmonk that it's out of scope for in here. Let's move discussion over to http://drupal.org/node/151984 where I proposed we display both the initial metadata and the current values (since I find the current UI of the initial vs. current metadata confusing). Let's just turn that into an issue about the UI at the top of issue pages.

@all: Oh right, the "active" class on the links -- hrm, nasty. Not sure what I think about that. Probably out of scope for this issue.

@all: I still don't like the wording for "followup", but I'll just fix that minor problem myself. hunmonk's already gotten way too much post-IFAC grief, I certainly didn't want to pile onto that. I had every intention of just fixing all of this myself (should have assigned to myself with my previous comment, in fact).

Nice work, everyone, thanks!

Changing followups to comments makes sense to me - it's more consistent with the rest of the UI (for instance I'm typing this under the heading "Post new comment").

Just wanted to point out that the functionality here was extended and improved by: http://drupal.org/node/189075

i've un-hacked bluebeach, because it was causing some other display issues on the site. so we're stuck w/ active-styled links for those for now...

Removes a couple more instances of followup/follow-up.

@webernet: thanks for those other updates, good catch. however, your patch was full of line-ending weirdness that was making it not apply cleanly. re-rolled to deal with that.

Committed to HEAD and installed on d.o.