Until recently the sender for issue follow-up notifications was the username of the user who updated the issue. But now every mail is send from '%project issue queue' (where %project is the name of the project/module). That makes it difficult to follow issue in the mailbox, because you must open every mail individually to see who updated the issue.

CommentFileSizeAuthor
#7 issue_mail2.patch1.94 KBprofix898
#5 issue_mail.patch1.13 KBprofix898

Comments

profix898’s picture

profix898 commented
Title: sender address changes with latest d.o. update » sender address and subject changed with latest d.o. update

And also in the the subject the [%project feature/bug/task] changed to [feature/bug/task] only. I couldnt find the issue where this change was introduced, but IMO thats regression. We lost information about the author of a followup completely.
All in all the mail output is far less intuitive and makes it very hard to follow the issues in the mailbox.

Not sure I consider this a bug/feature/task ...

heine’s picture

heine commented
Category: support » bug

It's a bug.

hunmonk’s picture

hunmonk commented
Category: bug » feature

it's not a bug. these changes were made explicitly, in part to fix an existing inconsistency: http://drupal.org/node/36619#comment-354534

the users who submitted the issue followup should be listed in both the metadata table and at the bottom of the most recent followup.

profix898’s picture

profix898 commented

Its looks like this was never discussed. For me and (I guess) for many other developers the notification mails are a vital element to follow updates on the queues. But actually with the recent change its a real pain.

Why not change the sender to username <noreply@drupal.org> (if you want to keep it consistent) and add the project back to the subject?

profix898’s picture

profix898 commented
Status: Active » Needs review
StatusFileSize
new issue_mail.patch1.13 KB

Ok, here is a simple patch that uses username <noreply@drupal.org>. We could also change this to username <issues@drupal.org> or sth., but please get the username back in place. Also adds the project name back to subject.

aclight’s picture

aclight commented
Status: Needs review » Needs work

I agree that it would be best to have the mail marked as coming from a user instead of the name of the project.

However, I don't think it's a good idea to hard code noreply@drupal.org as the sending address, but that's what this patch does.

profix898’s picture

profix898 commented
StatusFileSize
new issue_mail2.patch1.94 KB

I'm currently on the go and dont have access to a test environment, but here is a patch that allows the admin to specify the sender (and defaults to 'noreply@host').

profix898’s picture

profix898 commented
Status: Needs work » Needs review
aclight’s picture

aclight commented

I'm not sure it's worth spending much time on this for now. Hunmonk and dww have made it fairly clear that this is the expected behavior and that this behavior is desired.

I think they need to agree that this is a bug before we talk about how to fix it.

profix898’s picture

profix898 commented

Perhaps its expected behavior now, but it was different for several years and we had no discussion to change it. I'm getting really frustrated as my inbox is flooded with mails that I cant classify on the first sight. Am I the only one who is completely distracted by the new configuration?

hunmonk’s picture

hunmonk commented
Status: Needs review » Needs work

we had no discussion to change it

well, i've done my best to document the changes i've been making (and this change was clearly documented by me as i mentioned above), and to ask for feedback where it makes sense.

the only sure way for you to have a say in every decision related to project module is to be involved in the development process, and to keep up with the issue queues. the code that renders the emails like this has been in place for weeks, and i've been asking for feedback from people -- nobody complained about it until now.

I cant classify on the first sight. Am I the only one who is completely distracted by the new configuration?

i've received some feedback about the new layout, but it's hardly been an avalance of protest -- so i'm not convinced it needs to be different.

first, you can certainly classify with the new layout -- the sender text includes the name of the project. second, i personally think it's inaccurate to include the name of the person who submitted the update as the mail sender -- the mail was sent by the drupal site, on behalf of project's issue queue.

your patch is adding another setting when we already have a setting on the project page for the project email. also, it appears that your setting is global, while the current approach is per-project. i'm pretty sure we don't want this to be a global setting.

profix898’s picture

profix898 commented

the code ... has been in place for weeks, and i've been asking for feedback from people -- nobody complained about it until now

I guess the changes do not get much attention until they go live on d.o. You didnt receive usability feedback like http://drupal.org/node/188847 either until now.

first, you can certainly classify with the new layout

Yes, I can classify the project (although with the 'issue queue' in every line) its more difficult than before. I cant read the author from it (thats what this is all about).

i personally think it's inaccurate to include the name of the person who submitted the update

Well, in this case I guess there is nothing I can do about it :(
(except to point out that aclight agreed with me in #6 to include the user name)

aclight’s picture

aclight commented
Status: Needs work » Closed (duplicate)

We're going to take care of this in http://drupal.org/node/36619 since it's older and has more of the relevant background to why the change was made.