Geckoboard Push Statistics

Hi,

first of all there are quite a few issues to sort out such as indentation, whitespace.

You can find them all here:
http://ventral.org/pareview/httpgitdrupalorgsandboxzombienaute1889626git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

Manual Review:

Please add README.TXT file which tell about module's description, configuration, help, etc.

Hi acbramley,

I'm pretty new to Geckoboard, this seems to be a simple and useful module.
If Geckoboard Push module was meant to leverage just the API, this module does the right thing. Otherwise I guess you should consider to integrate your two Geckoboard widgets into the Geckoboard Push module.

I think you should also update the project page and list the widgets your module offers (as a list) and also specify a ToDo list (what widgets are you planning to release in near-by feature).

README.txt
You're saying people should reffer to README.txt of another project, paste a link there towards the module.

geckoboard_push_statistics.module
General question: Maybe you want to make a configuration page where you can limit fetched rows to a specific number and also filter those by type?

Also consider using db_select (as recommendation because of these reasons) here:
$results = db_query("SELECT severity, count(severity) FROM {watchdog} GROUP BY severity");
Use something like this:

$query = db_select('watchdog', 'w')
               ->fields('w', array('severity'))
               ->groupBy('severity');
$query->addExpression('COUNT(severity)', 'count');
$results = $query->execute()->fetchAll();

There's not much code/functionality so far, so as it is it looks pretty good. I think it's up to others to decide whether this can be a stand-alone module or not.

Thanks.

Note: Do not use db_select() for simple static queries, use db_query() instead. See http://drupal.org/node/310075

@klausi

For now it's simple and static, I was thinking that this module could also limit queries and select stuff from watchdog table according to specific selected type.

But to be honest I always thought that higher level db_select is always in favor of db_query, but I guess I was wrong, thanks :)

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/README.txt
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   8 | WARNING | Line exceeds 80 characters; contains 116 characters
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• This project on its own is too short to approve you as git vetted user, but I think you have enough other contributions so that we can give you the git vetted user role.

Looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cweagans as he might have time to take a final look at this.

Hi acbramley,

This looks great! Thanks for your contribution!

Normally, this project would be too short to get you approved as a vetted git user, but as klausi mentioned, you have a significant number of other contributions as well. Given that, I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewers as well.