Hi

if you have the image module installed and you install this module you get an error thrown by the create table since the table image_dimension already exists.

IMHO this shouldn't render in an errormessage to the user.

Comments

devin carlson’s picture

devin carlson commented
Status: Active » Postponed (maintainer needs more info)

I can't find any reference to the creation of an image_dimension table in either the core Image module or the Image module.

Which module is creating this table?

filijonka’s picture

filijonka commented
Status: Postponed (maintainer needs more info) » Active

hmm you're absolutly correct I must have misread greatly.
The only module that is creating this is file entity so I did some more checks and first time I install this it works fine but if making it unactive and then activating it again I get this error. Should it really call hook_install at all?
I did try this on a clean site to, D7.17.

jpwester’s picture

jpwester commented

I'm having the same issue which I have been unable to resolve. It seems to be the same as #1856298: Table "image_dimensions" already exists. (file_entity_update_7200). I have upwards of 10 sites using the same codebase, but something is unique about two of the sites that is causing them to fail when I try to upgrade this module with the error above. I'm also upgrading a number of other modules, as well as Drupal core.

ParisLiakos’s picture

ParisLiakos commented

Well maybe we should wrap the db_create_table in a table exists and be done with this weird error

jpwester’s picture

jpwester commented

That sounds reasonable enough to me. Who knows what is creating the table, but if that table exists, I can't upgrade this module. The only other alternative at this point is to manually delete the table, which isn't really feasible on our production environment. This is a better option than that!

ParisLiakos’s picture

ParisLiakos commented
Title: create table error » Check if image_dimensions exists before creating it
Version: 7.x-2.0-unstable7 » 7.x-2.x-dev

Lets do this. See:
#1447790-31: image_load makes admin/content/media unusably slow

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Fixed

Added checks for other calls to db_create_table as well
http://drupalcode.org/project/file_entity.git/commit/7822f79

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.