Download & Extend
Case Tracker » Issues

theme_casetracker_case_form_common isn't zero padding "Assign to" table rows

Posted by logaritmisk on January 22, 2013 at 10:24am
Project:Case Tracker
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

As the title says, theme_casetracker_case_form_common should zero pad the last row of the "Assign to" table, otherwise there is a chance it wont be equally many columns in the table body as there is in the table head.

Before:
Before

After:
After

AttachmentSize
theme_casetracker_case_form_common_zero_pad_assign_to-1.patch521 bytes
Login or register to post comments

Comments

#1

Posted by Simon Georges on January 30, 2013 at 9:27pm
Status:active» needs review

Changing status, as there is a patch.

#2

Posted by skyredwang on March 21, 2013 at 7:38am
Status:needs review» closed (won't fix)

I don't know why this is necessary

#3

Posted by logaritmisk on March 21, 2013 at 8:10am

From http://www.w3.org/TR/html401/struct/tables.html, Calculating the number of columns in a table:

Otherwise, if the TABLE element contains no COLGROUP or COL elements, user agents should base the number of columns on what is required by the rows. The number of columns is equal to the number of columns required by the row with the most columns, including cells that span multiple columns. For any row that has fewer than this number of columns, the end of that row should be padded with empty cells. The "end" of a row depends on the table directionality.

#4

Posted by skyredwang on March 21, 2013 at 8:53am
Status:closed (won't fix)» reviewed & tested by the community

Good documentation! Great suggestion! I learned a new thing!

#5

Posted by skyredwang on March 27, 2013 at 3:17am
Status:reviewed & tested by the community» closed (fixed)

committed http://drupalcode.org/project/casetracker.git/commit/fcad6a8

nobody click here