Motivation

It appears that Drupal 7 didn't have a colorfield module (http://drupal.org/project/colorfield)! I decided to fix that, discovered that a module existed called Colorfield, instead of duplicating the module i offered to help, the maintainer didn't answer and after few weeks i've been awarded the ownership of the module.
At the time the module didn't have a tagged release and wasn't finished, just a namespace reserved. I updated most of the codebase to remove code and use more efficiently the Drupal Field API and tagged a dev snapshot then 3 beta versions.
The code base can be browse here: http://drupalcode.org/project/colorfield.git/tree the automatic review of the code as been passed through PAReview: http://ventral.org/pareview/httpgitdrupalorgprojectcolorfieldgit-7x-1x

Features

Colorfield let the user pick a color through two widgets, either a split R, G, B color component, either with a color picker. By default it's using farbtastic, if you enable the submodule colorfield minicolors you can use an alternative color picker. This submodule is there to demo how to expose an other color picker.
Once the widget is selected you can display the color in three different ways, the first one is with a raw value, you can use that for injecting the color in anything (views for instance), the second one is about a color swatch, it displays a sample of the color in a block and the third one is about a configurable message that you can display colored (with the color you picked).
All of those formatters have options.

Past contributions

Projects maintenance

Projects application reviewed

I also helped having few core commits landing.
I got few projects promoted without passing the project application and wanted to fix that so here is my application! I hope it will be accepted.

Thanks for your time dear reviewer! :)

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

manual review:

  • jquery.minicolors.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Other than that this looks pretty ready to me. Licensing and third party code issues are blockers though. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Needs work » Needs review

The library has been moved out of the repository.

Thanks.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

Link to the project page and git clone command are missing in the issue summary, please add them.

I'm a robot and this is an automated message from Project Applications Scraper.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review

Poor PA robot only looks for sandbox links ... back to needs review.

brycefisherfleig’s picture

brycefisherfleig commented
Title: Colorfield » [D7] Colorfield

Adding drupal core version for (possibly) faster review experience

Anonymous’s picture

Anonymous (not verified) commented

Hey,

What exactly is the difference between this module and http://drupal.org/project/jquery_colorpicker ?

When adding a color field with the Color code widget I got this error right away: Notice: Undefined index: colorfield_options in colorfield_field_widget_form() (line 318 of D:\SITES\DEV\sites\all\modules\colorfield\colorfield.module).

Your code looks nice and clean.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Closed (won't fix) » Needs review

The main difference with http://drupal.org/project/jquery_colorpicker is that you can use the core colorpicker if you want (no extra dependency required) and if you want to use an alternative colorpicker, you can use a maintained colorpicker!

Your warning issue has been solved.

Thanks for the feedback.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Reviewed & tested by the community

I'm not sure what we're reviewing - you're already a co-maintainer on https://drupal.org/project/colorfield and have a 7.x-1.0 release out, nice work! Ventral.org doesn't find any major issues, and there don't appear to be security problems.

----
Top Shelf Modules - Enterprise modules from the community for the community.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Sorry, need a response about https://drupal.org/project/colorfield.

----
Top Shelf Modules - Enterprise modules from the community for the community.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented

I'm sorry but what is the question? Why is the module already a full project? Please re-read this part.

It appears that Drupal 7 didn't have a colorfield module (http://drupal.org/project/colorfield)! I decided to fix that, discovered that a module existed called Colorfield, instead of duplicating the module i offered to help, the maintainer didn't answer and after few weeks i've been awarded the ownership of the module.
At the time the module didn't have a tagged release and wasn't finished, just a namespace reserved. I updated most of the codebase to remove code and use more efficiently the Drupal Field API and tagged a dev snapshot then 3 beta versions.

I'm here to show that i can maintain projects, since i don't have the credentials to create new projects i need to pass the project application and i'm trying to pass it with the project i'm maintaining.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Postponed (maintainer needs more info) » Needs review
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Fixed

Ahh, thanks for the explanation!

Thanks for your contribution, Artusamak!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Enterprise modules from the community for the community.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented

No problem, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.