Token module integration is required for Pathauto 2.x as well as custom_pagers.

See Also:
http://drupal.org/node/190079
http://drupal.org/node/189517

Comments

ronan’s picture

Status: Active » Fixed

Added to HEAD.

niklp’s picture

Can you bump these into .dev please mate? It would make it a lot easier for me to test the changes out, I don't have a clue about CVS...

Cheers.

niklp’s picture

Status: Fixed » Active

Hmm.... this works, but... :)

The breadcrumbs are now fine, however the tokens now introduce a new issue. If I have created a root node, and section nodes beneath that, I have a nested structure. Obviously my root node relates to the home page.

However, if my home page is called "home", and I use the [fullhierarchytitlepath-raw] token, I end up with correct breadcrumbs, but the paths are like / for home page (obviously) and then for "services" section, I get "/home/services" and therefore "/home/services/service-1" etc.

I'm thinking that there are obviously advantages to having a root node, as you can display the children of the root node *in* the root node. However at the moment, to achieve the site structure with the right paths etc as I've described, the paths don't work, and I would have to delete the root node and use each section node as a root node.

I'm not sure, but I think this might make things more complicated - might it involve implementation of the concept of a "master" root node? Actually, maybe there could be a "default" home parent in the parent drop down? That would then make things more simple to implement I think.

Sorry for throwing more spanners in the works! :P

Edit: addition of the "master" node would also maybe help out with the breadcrumb issue...? Also, the other tokens suffer from the same problem, it's not just the [fullhierarchytitlepath-raw] one.

The home page would obviously be the best candidate for the site root - this is stored in the variable "site_frontpage", as a path string.

ronan’s picture

I've never actually built a structure with the homepage as the root (though I can see the advantage), so I've never encountered these issues. It makes sense that if the home page is in the path it should be ignored (after all the real and only path for the homepage should be '/')

I think fixing it this way makes more sense than adding more options and complexity to the system.

Also, I would recommend using the [fullhierarchypath] token for pathauto as this will allow you to change or override the generated urls and have the changes reflected in child urls. In fact, I think I will add the 'remove the homepage' logic to that token and not the others as it fits the logic of that token but not really the others.

ronan’s picture

Status: Active » Fixed

im gonna call this one fixed pending your feedback

niklp’s picture

Not sure what you have changed here...? I see no impact on the resulting paths. If my home page is called "front" I still get "front" in my paths. Hence, my paths look like this:

front                                          node/1
front/story-1                               node/2
front/story-1/story-1a                    node/4

and they should be like this, as the "front" node is supposed to replace the home page:

front                                          node/1
/story-1                                     node/2
/story-1/story-1a                           node/4

I note that there is no check in the token code to establish whether or not the front segment of the path is the home page, and negate it if that is the case. I can't see how this part of the module will work without either that check (again, against the site_frontpage variable, presumably) or the "magic" node as previously described.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

niklp’s picture

Status: Closed (fixed) » Active

Still an issue here, should have changed the status previously.

niklp’s picture

AFAIK this is still not fixed - I am not really happy about using this module until this fix is implemented - should be fairly simple, no?

dgorton’s picture

Status: Active » Closed (duplicate)

Duplicate of #190168 - and solved there.