Posted by brantwynn on January 29, 2013 at 5:47pm
5 followers
| Project: | UUID Features Integration |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | demo_framework |
Issue Summary
See: #965450: Add component that exports vocabulary with all its terms & #1800606: _uuid_features_default_terms() parent key (term hierarchy)
Please make sure to run coder and test patches before committing them, and especially before tagging a new release.
Patch attached. :)
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| uuid-features-remove-html-characters.patch | 1.45 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch uuid-features-remove-html-characters.patch. Unable to apply patch. See the log in the details link for more information. | View details |
Comments
#1
For anyone googling, this is a fix for the exception "Parse Error: parse error, expecting `T_VARIABLE` in /uuid_features/uuid_features.module on line 64" happening when you try to install uuid_features-7.x-1.0-alpha2
#2
Patch is failing now, both the latest dev (as of 1/29/2013) and alpha2 have this issue now, preventing the module from installing.
This is the output from my terminal when trying to apply the patch:
patch < uuid-features-remove-html-characters.patchpatching file uuid_term.features.inc
Hunk #1 FAILED at 90.
1 out of 1 hunk FAILED -- saving rejects to file uuid_term.features.inc.rej
patching file uuid_features.module
#3
Can anyone confirm that the 7.x-1.0-alpha3 version is working fine?
#4
The alpha3 version installs fine now. I would advise against doing so many releases. Typically this is done in a more controlled fashion.
A couple questions, please don't take this the wrong way:
1. How is it you came about maintaining this module?
-- The community appreciates your efforts! Just wondering when/where this decision was made.
2. Have you gone through the process of applying for access to promote projects from sandbox to full status?
-- I am asking the second question because I found, in my experience going through this process, it is quite rigorous, and prepares individuals to go about using best practices when maintaining modules. I would assume anyone who has gone through this process would be using proper commit messages, attributing authorship from patches applied and committed, and would at least lint the code before promoting it... let alone creating a release candidate.
-- http://drupal.org/node/1011698
Also, this was a bug report so it should have be filed against dev. I guess you changed it to alpha3 because you want people to test the new release now?
-- http://drupal.org/node/73179
I'm marking this as 'needs review' until at least one other individual comes along, tests your release, and confirms it working as I have.
#5
The last submitted patch, uuid-features-remove-html-characters.patch, failed testing.
#6
@AlfTheCat The patch above was to be applied to
66d29d072c8ef7cd29d2c678ed426eec7e46b342- you were possibly patching against the HEAD? It appears to me that Jeffrey C. did a commit right around the time you were testing this.In any case, the patch was "applied" here: 1a2d661
Please take a stab at using alpha3, it is working for me at this time.
#7
Agreed - Jeffrey C, your efforts are definitely appreciated!
Looking at the revisions for the UUID Features Project page it looks like Jeffrey C. became co-maintainer through the unsupported projects process. I regret that I and the other co-maintainers were tuned out enough from the issue queue at that particular time that we missed your request to co-maintain the project.
Looking at Jeffery C's participation in the Project applications issue queue, reveals 2 issues - #1626870: Login Redirect appears to be the one where Jeffery C. made it through the project approval process, apparently before changing his username from legendm33066.
Agreed this is a good idea, even in alpha releases such as this one. At the same time, it's worth noting that occasionally even the most experienced project maintainers make a release that contains fatal errors. One of the top 5 most used Drupal contrib modules once had a security advisory release with a parse error!
@Jeffrey C. - Thanks for your work on this module! I suggest taking a moment to review the best practices for co-maintaining projects , in particular the section on formatting commit messages.
Looking forward to working with you to bring this module towards a stable 7.x release!
#8
It appears that my comment in #7 quotes a comment that has since been edited.
#9
Yeah, I put the text back after it was quoted - the questions were originally removed as I felt I was being a bit harsh. No worries, ezra-g.
Thanks Jeffrey C. for your work on this module, I'm excited to see it has been resurrected!
#10
Some more history, since we're digging... Jeffrey C was/ is also the maintainer of the defaultcontent module http://drupal.org/project/defaultcontent and took over UUID Features because of the overlap in functionality, amongst other reasons. http://drupal.org/node/1869366
I really applaud his efforts, for years I've been following and struggling with the import and export of nodes and all that is attached to them. It is an extremely difficult thing to tackle in Drupal yet at the same time extremely valuable especially for those who are working with distributions. I am really looking forward to the day where exporting content to features becomes painless.
I will test the alpha3 today and post back, just wanted to chime in and say thanks to Jeffrey :)
#11
Hmm... smells like some history here :). First of all let me thank you all, for reviews and the support :). Two months ago I was working on a project and also struggled to export contents to a Features exportable, I used Default Content, sicked of having to enter the machine name for every node, then turned to UUID Features. However UUID Features was still in alpha1 and did not work at all with the latest version of UUID. After I finally figured how to get it work (I also filed an issue just to help other users stuck here like me, #1861778: For any of you who can't get this module to work), I started to work hard to have both modules pushed forward. Unfortunately, there's really not much you can do without (co-)maintainership, so I simply contacted the original project owner and filed an issue again and finally took over them. Well, you guys know the rest. But I'm still having a hard time figuring how UUID Features works so can't provide patches for it at this time. Probably have to dig into Features' documentation again.
Just a note, I did not apply any patch for this issue, I'm so afraid that something might go wrong or we might miss something, instead, I paged through the code and make sure there's no more weird HTML code.
Also, marking this as fixed, but comments are welcome :).
#12
By the way, thanks for the advice I'll make sure I follow them the next time :).
#13
Automatically closed -- issue fixed for 2 weeks with no activity.