Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
CSS
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Jan 2013 at 09:49 UTC
Updated:
29 Jul 2014 at 21:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rcaracaus commentedI have tried my hand at submitting a fix for this. However there are still some design decisions that need to be made.
This fix reverts to the themes default padding for ols, adding back a padding of what looks like 15px to the left. The bad part is that the border is also pushed over, can't think of a way to fix that without adding extra markup and adding negative padding. Not sure if this is an issue, it beats not the numbers being cut off on mobile and the numbers being pulled between the columns even on normal displays.
Comment #2
rcaracaus commentedComment #3
echoz commentedHow about list-style-position: inside; and I think it looks better wide too, so not wrapping with a media query. Note that the ol qualifier was needed on the selector :-( and @rcaracaus, you know there's no such css as negative padding, right?
Comment #4
rcaracaus commentedNice.. I didn't know about list-style-position: inside; That is very useful... also I meant to say negative margin.
Comment #5
rcaracaus commentedI tested this locally.. and looked at it in different displays.. looks good.
Comment #6
shyamala commentedadding tags
Comment #7
echoz commented@rcaracaus, so is the patch in #3 rtbc for you? The file hasn't changed since so it should apply fine.
Comment #8
echoz commentedtags removed by d.o unintentionally
Comment #9
rcaracaus commentedI have tested the patch and it looked OK to me. I am not sure what standards are for rtbc.
Comment #10
carwin commentedPatch in #3 applies cleanly and
list-style-position: inside;seems like a fine solution to the problem.RTBC. Huzzah!
Comment #11
webchickAwesome work on this!
Committed and pushed to 8.x. Thanks!