As pointed out in http://drupal.org/node/1757564#comment-7001904 the wrong config key is used by a mistake.

CommentFileSizeAuthor
#7 drupal-1903410-7.patch4.55 KBdawehner
#3 interdiff.txt792 bytesdawehner
#3 drupal-1903410-3.patch4.55 KBdawehner
#1 drupal-1903410-tests.patch4.1 KBdawehner
#1 drupal-1903410-1.patch4.66 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
Issue tags: +VDC
StatusFileSize
new drupal-1903410-1.patch4.66 KB
new drupal-1903410-tests.patch4.1 KB

Adapted the existing tests, but yeah if you want to be strict there is a lot to be testet.

damiankloip’s picture

damiankloip commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayFeedTest.phpundefined
@@ -48,11 +48,11 @@ protected function setUp() {
+  public function _testFeedUI() {

I think we need to lose the _ again.

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayFeedTest.phpundefined
@@ -68,14 +68,39 @@ public function testFeedUI() {
+   * Tests the actual output.

'Tests the rendered feed output' or something instead?

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayFeedTest.phpundefined
@@ -68,14 +68,39 @@ public function testFeedUI() {
+    $views = $this->container->get('plugin.manager.entity')->getStorageController('view')->load(array('test_feed_display'));

This stuff is getting insanely long and ugly, but hey, that's not your fault!

Otherwise, all the tests look fine.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-1903410-3.patch4.55 KB
new interdiff.txt792 bytes

Thank you for the review, hard to get one these days.

olli’s picture

olli commented
Status: Needs review » Reviewed & tested by the community

#3 solves the problem, adds coverage and fixes #2.

Maybe DefaultViewsTests could test rendering the views too.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -VDC

#3: drupal-1903410-3.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +VDC

The last submitted patch, drupal-1903410-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-1903410-7.patch4.55 KB

Rerole.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, drupal-1903410-7.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
Issue tags: +VDC

#7: drupal-1903410-7.patch queued for re-testing.

olli’s picture

olli commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.