Preliminary support for synchronizing Salesforce contact and lead updates

I've applied your patch and I'd like to test your features. I'm happy that you've developed all the mentioned functions. I think it's absolutely necessary that we're having functions to synchronize the data between Salesforce and Drupal. From my point of perspective the patch should go into the module as core functions (after review). What do the other users think? What about you Victor? Right now I'm missing an overview what we want to achieve with the salesforce module. Why don't we setup a place (like a group) where we can discuss the core functions/features/additions of the module?

After a first test in my log file appeared the following error:
type: php
message: Invalid argument supplied for foreach() in /sites/all/modules/salesforce/salesforce.module on line 569
severity: error

This is the code:

function _salesforce_cron_user_update($updated, $type='contact_id') {
  foreach($updated as $id => $user) {

I haven't done something special. I've just applied your patch and changed a lead in Salesforce.

"Why don't we setup a place (like a group) where we can discuss the core functions/features/additions of the module?"

We have done just that! We are using the already existing group Enterprise CRM Integration

http://groups.drupal.org/enterprise-crm-integration

for this, and on the basis of various discussions, we have started the following Salesforce specific thread:

http://groups.drupal.org/node/7065

Thank you Victor for the group. I will definitely take part in the discussion...

Hi eojthebrave,
I've done some further testing. Here are my results:

1. Lead - create
name: Lead Test2
result:
- user - New user: LeadTest2 created, status: blocked
- salesforce - Inserted user LeadTest2 from Salesforce
- since I've inserted email address login data was sent and event was created (don't know where to find this)
suggestions:
- there should be a function which transforms the usernames in lower case
- We should come up with a function to make sure that German umlauts and other special chars are recognized by your update function. In Salesforce I've added an account with my name "Björn Jacob". The new user in Drupal is named "Bj Jacob". As you can see the first name is cut off.

2. Lead - update
name: Lead Test2
result: user "LeadTest2" was updated, but sometimes error message in log (I had to start the cron manually 3 times):

EDIT !!!
---------
php: Invalid argument supplied for foreach() in /sites/all/modules/salesforce/salesforce.module on line 569.
php: Invalid argument supplied for foreach() in /sites/all/modules/salesforce/salesforce.module on line 569.

3. Lead - delete
name: Lead Test2 "LeadTest2"
result: user not deleted
question: Am I doing something wrong? What do you want to achieve? What happens if someone deletes a lead in Salesforce? Does Drupal delete the user or does Drupal change the status say from active to blocked? What do you suggest? I think status blocked is better.

I've also recognized that the page admin/content/salesforce/lead is not updated properly.

And I'm getting again the error message which I've described above (lin 569). I don't know if it's related to the update task or to the delete task...

EDIT !!!
----------
4. Lead - convert
name: Lead Test2 "LeadTest2"
result: success, status of user is now "active", appears under admin/content/salesforce/contact (moved from admin/content/salesforce/lead), log shows the following:
- salesforce: Updated LeadTest2 from Salesforce
- salesforce: Updated LeadTest2 from Salesforce

Just one thing: Drupal shows the wrong phone and fax number. In Salesforce the number is for both fields "111". Drupal shows "11". But this can also be a problem which is related to the many entries I've done. I will check it later.

Thank you for your fast reply. I'm happy that I could help somehow (with my limited PHP knowledge)...

"- since I've inserted email address login data was sent and event was created (don't know where to find this)
suggestions:"

Is this something that Salesforce is doing or Drupal? If Drupal, the way the new user registration is set up it should function exactly the same as if the administrator went and filled out the Add a New User form. So, depending on how your Drupal installation is configured this will vary. If it's something else though ... I'm not really a Salesforce expert as this is my first foray, so any insight would be helpful.

What did I do? I've created a new lead in Salesforce (entered the following data: first name, last name, company, phone, fax, email). Then I've run the cron manually. After that Drupal told me it has created a new user and email with login data was sent (as you said it depends on the registration process in my Drupal version). Everything is fine and works very well. Furthermore it appeared a message which said an event was created. I think this is something in Salesforce, isn't it? I couldn't find a new event in Salesforce. So this made me wonder. We have to figure out what should happen. Maybe its not working because of this line in salesforce.module:

function salesforce_form_lead_submit() {
...
$result = salesforce_event('insert', $_POST['edit']['form_id'], $message, user_load(array('mail' => $_POST['edit']['mail'])));
...
}

Yesterday I've posted a problem and Victor came up with a solution (http://drupal.org/node/191527). There was a problem with the $_POST variable. Maybe we can try this line:

$result = salesforce_event('insert', $form_values['form_id'], $message, user_load(array('mail' => $form_values['mail'])));

"- We should come up with a function to make sure that German umlauts and other special chars are recognized by your update function. In Salesforce I've added an account with my name "Björn Jacob". The new user in Drupal is named "Bj Jacob". As you can see the first name is cut off."

At the moment I really have no idea how to go about dealing with this. So if you or anyone else has suggestions on how to handle the encoded characters let me know. In the meantime I'll work on abstracting the username creation into it's own function so that it's easier to modify in the future.

It is a good idea having a seperate function for the username creation. The problem with the umlauts... mmh. Maybe we need something like utf8_decode. Or is it a problem with the database. I've looked it up on drupal.org (see http://drupal.org/search/node/german+umlauts). I will check my database settings and let you know. Someone wrote Drupal supports utf8 now...

Plans: upon new version making this two-way synching optional via admin panel (checkbox somewhere), this patch will be committed to current 5.x dev release.

I've applied your great patch but I receive the following error message:

Fatal error: Call to a member function getUpdated() on a non-object in /sites/all/modules/salesforce/includes/salesforce_api.inc on line 499

The line is:

$res = $salesforce->getUpdated($type, gmdate('c',$startDate), gmdate('c',$endDate));

I think you are right. I had to change my Salesforce password in order to give my manager the ability to get access to my developer account. I'm so stupid! But this shows again that we need a global validation function which checks if the salesforce login data is correct... In my case I've tried to run the cron job manually. Then I've received the error message. Anyway, thank you for your adivce!

More testing with your new patch (after my Salesforce connecting is up and running again):

1st TRY
======
1. Lead - create (Salesforce --> Drupal)
- name: Lead Test1
- results (recent log entries)
- user - New user: LeadTest1 <>. <-- Why do we get these brackets? EDIT: I see: I didn't enter an email address... Within these brackets the email address is supposed to be displayed.
- salesforce - Inserted user LeadTest1 from Salesforce
- status of user: blocked
- problems
- Company not filled out (but we now the problem, right?!)

2. Lead - update (Salesforce --> Drupal)
- name: Lead Test1
- results (recent log entries)
- salesforce - Updated LeadTest1 from Salesforce
- no problems, no php errors anymore! Great!

2nd TRY
=======
1. Lead - create (Salesforce --> Drupal)
- name: Lead Test2
- results after cron run/problems

* user warning: Duplicate entry 'LeadTest2' for key 2 query: INSERT INTO drupal_users (name, mail, pass, init, uid, created) VALUES ('LeadTest2', 'email@domain.de', '2fd1aab3f511eef13e7ea5293e50ac23', 'email@domain.de', 16, 1196415002) in /includes/database.mysql.inc on line 172.
* user warning: Duplicate entry '0' for key 1 query: INSERT INTO drupal_salesforce_users (uid,lead_id,account_id,created) VALUES (0,"00Q7000000J5NBbEAN","",1196415002) in /includes/database.mysql.inc on line 172.

--> Every time the cron runs it tries to create this user. In the recent log entries you can find the following messages:
- salesforce - Inserted user LeadTest2 from Salesforce
- php - Duplicate entry 'LeadTest2' for key 2 query: INSERT INTO drupal_users (name, mail, pass, init, status, uid, created) VALUES ('LeadTest2', 'email@domain.de', '4501359faf5b2ded4fcfdc2c54d56293', 'email@domain.de', 0, 18, 1196415354) in /includes/database.mysql.inc on line 172.

What happend? Some days ago I've testesd the module. I created a new lead "Lead Test2" in Salesforce and synchronized it with Drupal. The user LeadTest2 was created and is active since then. Later I've deleted the Lead/Contact in Salesforce but the user was not deleted in Drupal. Somehow it was still active. What can we do? Is this useful information? Is this a case which can happen in the real world as well? I still think we shouldn't delete users in Drupal. Do we have to come up with another if-case? If such a naming-problem happens should we create a new user with a slightly different username like "LeadTest2_1" or something like that?

3rd TRY
=======
1. Lead - create (Salesforce --> Drupal)
- name: Lead Test10
- results (recent log entries)
- user - New user: LeadTest10 .
- salesforce - Inserted user LeadTest10 from Salesforce
- status of user: blocked
- Drupal login email is sent

2a. Lead - update (Salesforce --> Drupal)
- name: Lead Test10
- results (recent log entries)
- salesforce - Updated LeadTest10 from Salesforce
- no problems, no php errors anymore! Great!

2b. Lead - update (Drupal --> Salesforce)
- name: Lead Test10
- activated user in Drupal
- messages:
- updated lead in salesforce for the user Lead Test10
- The changes have been saved.
- An event was created in salesforce for the user Lead Test10
- checked Salesforce:
- new event: user_edit - Friday, November 30, 2007 - 10:50 <-- Why do we get these html tags?
- problems
- in a second browser I've logged in as LeadTest10 and edited my account data (phone, fax)
- the data was not changed in Salesforce
- no event was created in Salesforce
- EDIT: if inserted a company name (existing one in Salesforce) and changed the phone number and received the following message:

warning: htmlspecialchars() expects parameter 1 to be string, object given in /includes/bootstrap.inc on line 631.

and another problem in the recent log entries:
salesforce - invalid cross reference id - for the user %user

I think this is related to the Company Problem

3a. Lead - delete (Salesforce --> Drupal)
- name: Lead Test10
- results (recent log entries)
- nothing
- problems
- nothing happend, i.e. user in Drupal still active (cron ran 4 times)
- EDIT: after a long time (30 minutes / 6 cron runs) the user LeadTest10 was not avialable anymore under /admin/user/user and admin/content/salesforce/lead --> so it seems that this function is working

3b. Lead - delete (Drupal --> Salesforce)
- name: Lead Test20
- results (recent log entries)
- user - Deleted user: LeadTest20 .
- user - New user: LeadTest20 .
- salesforce - Inserted user LeadTest20 from Salesforce
- problems
- as you can see the user is deleted and the entry under admin/content/salesforce/lead is removed. great! but a new user is created in Drupal because the old lead is not deleted in Salesforce. I know it's not a bug it's a feature. So what should happen if someone deletes a user in Drupal?
- another wired thing happens:
- I've deleted some other users in Drupal (they were created some weaks ago related to my first tests)
- after a cron run I'm getting a lot of messages like this:
user - Deleted user: <>.
salesforce - Deleted user because the Lead was removed from Salesforce

So it seems that the cron is hanging somewhere...

4. Lead - convert
- name: Lead Test30
- status: blocked
- messages after manual cron run
- Password and further instructions have been e-mailed to the new user LeadTest30.
- user warning: Duplicate entry 'LeadTest30' for key 2 query: INSERT INTO drupal_users (name, mail, pass, init, uid, created) VALUES ('LeadTest30', 'email@domain.de', '950cf3971cebc7194367d099f50ae713', 'email@domain.de', 23, 1196421375) in /includes/database.mysql.inc on line 172.
- results (recent log entries)
- php ... (see above)
- user - New user: LeadTest30 .
- salesforce - Inserted user LeadTest30 from Salesforce
- salesforce - Updated LeadTest30 from Salesforce
- BUT: the user is now active in Drupal :)
- user appears under admin/content/salesforce/contact (moved from admin/content/salesforce/lead)

Okay, enough testing for now. Let me know if this helps you a little bit...

Thank you very much for your patch! It's great that you put such a lot of effort in this. Wow! I've applied your fix but somehow Drupal says "Failed to authenticate on SalesForce.com". I don't understand the problem. I didn't change my login data. Therefore it should work. Now I've installed a new Drupal (5.5) and installed all the modules but still the same problem. I've checked my login data several times. Do you encounter the same problem?

I think it's great that you are testing the patch and your work is a great contribution to the efforts which will be crowned shortly with the official release of the Salesforce module for Drupal 5.x and the complete refactoring / redesign for Drupal 6.

However, please don't change a thread to a bug report when dealing with patches not made part of the development release.

Am changing from bug back to feature request (there is no bug report relative to any official or development release of the modules, and there is an advisory on the patch that it is not ready for prime time).

Thanks. I've installed the recent version of the salesforce.module (without any changes). I've created a new page and pasted your code (entered my username and password which I had checked at salesforce.com). I've received the following message:

Fatal error: Class 'salesforce' not found in /includes/common.inc(1347) : eval()'d code on line 6.

Then I've entered my username and passwort several times and got all the time the same message: "Failed to authenticate on SalesForce.com". It's a new installation of Drupal and it should work. Right now I've no idea. Is there anything I can administer in salesforce.com? Is there a function which I've switched on and now I've got a problem... ?

Thank you for any help.
Bjoern

EDIT: I'm a little bit angry. Today I found the reason why it's not working. I've changed my salesforce password (it was my last hope) and I received an email. There a security token was enclosed. And that's the solution! I have to combine the password and the token and now my system is running again...

@victorkane: I'm sorry that I've changed the category of this post quite often. You are absolutelly right and I understand what you are saying. It's my first time that I'm working with this "bug tracker"...

I've done some more testing ;)

Fixed problem with duplicate usernames when a Contact/Lead has the same name as another. Now when users are imported from Salesforce if there is already a user with the same name it will add a unique integer to the end of their username. ie.).

TestUser, TestUser_1, TestUser_2, etc ...

That's a great function but I think I've found a problem:

• created new contact, name "Test Contact1
• run cron, new user was created, username "TestContact1"
• updated contact in Salesforce, changed last name
• run cron (within 600 seconds since last run), new user was created "TestContact1_1"
• updated contact in Salesforce, changed phone number
• run cron (within 600 seconds since last run), new user was created "TestContact1_2"

What can we do? Should we tell the administrator not to run the cron within 600 seconds? Should we check the ContactID or something like that?

I've got a question about a database query. You can find it in line 426, function salesforce_contact_select()

$contact = $salesforce->query("SELECT ". implode(',', $params) ." FROM contact WHERE Id = '". $account->salesforce['contact_id'] ."'");

I couldn't find an "Id" field in the Salesforce API documentation. Why don't we use "AccountId" which is documented?

Another question. As I reviewed your changes I've seen the following lines:

if (!variable_get('salesforce_contact_sync', 0) && !variable_get('salesforce_lead_sync', 0)) {
  $fields['Company'] = $account->company;
}

What's the purpose of this code? Do you want to insert the company name into the appropriate field in Drupal? If yes I think it's not working on my system. After several cron runs the company field is still empty in Drupal.

Thank's again for your work and effort!

eojthebrave, I just wanted to ask if you could make some progress. Is there anything I can do to help you a little bit?

Thanks eojthebrave for your patch. I've applied it and I'll test the new features ASAP. You're asking what I want to accomplish. Okay, here's the plan:

• Overall, I need a Drupal system where customers can post cases and receive answers/comments (i.e. I want to synchronize Salesforce cases and comments).
• First of all, I have to synchronize all Contacts which are flagged as Self-service users (SSU) in Salesforce. Each user should have an own profile in Drupal which he can view and update. Before your last patch came out only a few profile fields could be synchronized but now we can have custom fields and (I hope) the standard Salesforce fields as well. After a special period (of x days) the user has to confirm his profile data. If a admin removes the flag 'self-servive user' the account is blocked in Drupal. Furthermore, I have to come up with a solution for 'super users' (Salesforce). It enables the customer to view case information, add comments, and upload attachments for all cases submitted by anyone in his or her company.
• Synchronization of cases from Salesforce to Drupal: cases which are flagged as 'visible in self-service portal' have to be synchronized with Drupal.
• Synchronization of cases from Drupal to Salesforce: cases which are created in Drupal have to be synchronized with Salesforce.
• Synchronization of comments: comments which are written in Drupal have to be synchronized with Salesforce. Comments which are flagged as 'visible in self-service portal' have to be synchronized with Drupal.
• Users should be able to attach documents (maybe even to comments) which will be synchronized.

What needs to be done:

• Implement function to synchronize contacts which are flagged as SSU.
• Implement function to change the user rights for Salesforce 'super users'.
• Implement function to only synchronize cases which are flagged as 'visible in self-service portal'.
• Implement function to synchronize comments, include flag function.
• Synchronization of attachments.

I think this is a lot of work which has to be done. I've found a developer who's currently working on some issues.

To achieve some of our goals it would be great if you could fix the problem mentioned in comment #20 (http://drupal.org/node/190631#comment-655676).

We've also found some other problems in your great salesforce_cases.module (see comment #8 http://drupal.org/node/193235#comment-664314). Yesterday, the developer could come up with some answers to the questions in comment #8. He told me he wants to post his ideas/solution/whatever today...

---

EDIT: I think I've found a bug. As I said I've applied your patch. Then I've created a new profile field called 'sf_MobilePhone'. The field 'MobilePhone' is a standard field in Salesforce. Watchdog prints the following errors:

array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #2 is not an array in /sites/all/modules/salesforce/salesforce.module on line 719.

array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #2 is not an array in /sites/all/modules/salesforce/includes/salesforce_api.inc on line 444.

implode() [<a href='function.implode'>function.implode</a>]: Bad arguments. in /sites/all/modules/salesforce/includes/salesforce_api.inc on line 452.

I'll check the source again.

After some tests I realized that I can't synchronize contacts anymore. The PHP error makes it impossible.

And I think I've encountered another problem. Here's what I did:

• Went to my administator account and updated fields. By chance the checkbox "create a lead in salesforce" was marked and I saved the profile.
• Now the Salesforce log (admin/content/salesforce) shows one task (type "lead insert"). The cell "message" says "Required fields are missing: [Company]".
• When I click on one function (say delete) I receive a 404. The link is "http://www.domain.de/admin/salesforce/log/delete/1".

eojthebrave, I'm totally sorry. In order to develop own functions I've added some new lines to the module and api files. Therefore the line numbers are not very helpful. Line 719 in salesforce.module is the following one (function _salesforce_cron_user_update):

$contact = salesforce_contact_select($account, array_merge($fields, $profile_fields));

Line 444 in salesforce_api.inc is the following one (function salesforce_contact_select):

$params = array_merge($defaults, $params);

Line 452:

$contact = $salesforce->query("SELECT ". implode(',', $params) ." FROM contact WHERE Id = '". $account->salesforce['contact_id'] ."'". $limiter);

In the meantime something has changed. Now it seems to work. The other day (after I've applied your patch) I've dropped each and every table which was related to the salesforce and salesforce_case module. I cleared the system table and the profile tables. Afterwards I've made a new installation of the salesforce module. I've deleted all users. Then I've added a new field sf_MobilePhone and now it's synchronized. I don't know why it wasn't working. Maybe some old data caused the problem.

Great work, indeed!

As soon as I can I will review and test, and commit.

If we are sure everything is stable, we should come out with the 5.x stable version.

Then we can get on with the roadmap (new features for the 6.x.dev version).

Hi there,
wow this is just awesome! I've applied the patch and started testing some of the features. As you know I've also installed the salesforce_case.module. After I've run the cronjob manually I've received the following error in the status log:

Invalid argument supplied for foreach() in /sites/all/modules/salesforce/salesforce_case.module on line 119.

The corresponding line in salesforce_case.module is:

foreach($res['deletedRecords'] as $record) {
					$deleted[] = $record['id'];
				}

in function salesforce_case_cron().

I found out that the new partner.wsdl is causing the error. I've replaced the new one I've downloaded today with the old one and the error is gone. So what can we do in order to use the new partner.wsdl?

On Monday I'll spend more time on testing the module. So Victor if you can wait till Monday... :)

Absolutely, thanks for your enthusiasm.

In any case, we need to identify the subset which will be needed by most users.

(corrected inadvertent change of issue title)

1. created contact (Salesforce -> Drupal)
settings

• Synchronize contacts in Salesforce: true
• Contact default account status: active
• Synchronize leads in Salesforce: false

result

• user was created in Drupal, status: active
• custom profile fields filled

problem

• known "problem" with field company/account -> I think this field is important and it should be synchronized before the module version is changed to stable.

2. updated contact from test 1 (Drupal -> Salesforce)
result

• changed profile fields (phone, sf_Title) --> changes were synchronized

problem

• known problem with checkbox "create a lead in salesforce" on pages "Account settings" and "Personal Information"

3. created contact (Salesforce -> Drupal)
settings

• Synchronize contacts in Salesforce: true
• Contact default account status: blocked
• Synchronize leads in Salesforce: false

result

• user was created in Drupal, status: blocked
• custom profile fields filled

no problems

4. created contact with same name as in test 1 (Salesforce -> Drupal)
settings

• same name as in test 1, different email address

result

• new user with suffix _1 was created in Drupal

no problems

5. created contact with same name and same email address(Salesforce -> Drupal)
settings

• same name and same email address as my user uid=1

result

• user uid=1 was updated properly

no problems

6. deleted 2 contacts (Salesforce -> Drupal)
process / result

• deleted 2 users in Salesforce which were active users in Drupal
• only one user was blocked the other Drupal user is still active

7. deleted contact (Drupal -> Salesforce)
process / result

• deleted 1 user in Drupal which is a contact in Salesforce
• contact was not deleted in Salesforce
• instead new user was created in Drupal

conclusion
--------------
IMHO we have to address the following issues:

1. Synchronization of field company/account.
2. Unchecking checkbox "create a lead in salesforce" impossible.
3. After all these tests it seems that there's still a problem with the module. The cronjob runs every 5 minutes. With every run all of my users created in test 1 to 4 are updated again and again (I haven't changed a thing since the last 45 minutes) log message "salesforce - Updated TestContact19_1 from Salesforce"). The same happens with my user updated in test 5. The user which was deleted in test 6 is blocked every run as well ("Blocked user because Contact was deleted in Salesforce").
4. We should come up with a function to make sure that German umlauts and other special chars are recognized. In test 5 the first name of the user was Björn. Drupal the first name is cut off after Bj.
5. Problem with deleting more than one user in Salesforce (test 6) and "problem" with deleting users in Drupal (test 7). I think test 7 is not a problem. It is a good idea not to delete the contact in Salesforce. But I think we should come up with a function which prevents creating this contact again in Drupal.

Tomorrow I will do the same tests with leads.

Thanks eojthebrave for your patch. I've applied it and I'm very happy what you've accomplished. But right now I've got some serious problems. All the testing has massed up my system. Therefore I've installed a brand new Drupal on a different Server with a different IP address. I've activated some modules (cck, views, token, pathauto) and set up salesforce.module. Then I went to admin/settings/salesforce and entered Salesforce username and password...

I know it's an old story but I can't connect to Salesforce. All the time I'm getting the message "Failed to authenticate on SalesForce.com" and when starting the cron I'm getting a PHP error:

#
Call to a member function getUpdated() on a non-object in /sites/all/modules/salesforce/salesforce.module on line 253

So I started investigating the problem: checked my password settings; changed password; received new security token and added it to my password; went to Salesforce Admin area and added via Setup / Security Controls / Network Access my IP and the IP of the server (even IP ranges); went to Setup / Manage Users and checked login History (no event i.e. salesforce.module is not even trying to connect); downloaded new partner.wsdl; tried a second developer account login data (same problem)... As you can see I've done a lot but still it's not working.

Any ideas?

I've done what you've supposed. Drupal prints an extremely long list. Right now I don't know what's important to look at. If you want you can find the formatted output file at http://www.drupal.contrend.de. It would be great if someone could have a look on it.

Salesforce doesn't return any error message :(

--- edit --- sry, same as #37 ---

Thanks eojthebrave, the problem was my partner.wsdl. I've downloaded the .wsdl you've provided at http://drupal.org/node/214224. Now it seems to work...

Our project is moving forward and I had time to test the synchronization of contacts. I've got an existing contact in Salesforce. The contact was synched to Drupal. So far everything is okay.

Now I've logged in as the user and went to the user's account page (/user/xxx) and edited the "Personal information". I've changed the fields "Phone" ($user->phone) and the "Title" ($user->sf_Title). This is synched to Salesforce. After that I've cleared the fields for phone and title (empty fields) in Drupal. I've started the cron and instead of having no values the phone and title fields showed the old values which are stored in Salesforce and should be overwritten.

IMHO we have to write a function which pays attention to this special case. Do we have to include a timestamp check or something like that (or a check to find out which entry is newer)...

EDIT: I've seen that the same happens when clearing a field which was generated by the salesforce_case module.

I've got another question. I would really like to synch the company field (in Salesfore name of account). How can I achieve this? I went to the salesforce_api.inc and changed the following lines in function salesforce_contact:

case 'insert': case 'update':

$fields = array(
'Company' => $account->company,
'FirstName' => $account->first_name,
'LastName' => $account->last_name,
'Phone' => $account->phone,
'Fax' => $account->fax,
'Email' => $account->mail,
);

$fields = _sf_profile_fields_put($fields, $account);

//if (!variable_get('salesforce_contact_sync', 0) && !variable_get('salesforce_lead_sync', 0)) {
//  $fields['Company'] = $account->company;
//}

and

case 'update from remote':
...
$fields = array(
'Company' => $contact->company,
'first_name' => $contact['FirstName'],
'last_name' => $contact['LastName'],
'phone' => $contact['Phone'],
'fax' => $contact['Fax'],
'update_from_salesforce' => TRUE
);

$fields = _sf_profile_fields_get($fields, $profile_fields, $contact);

//if (!variable_get('salesforce_contact_sync', 0) && !variable_get('salesforce_lead_sync', 0)) {
//  $fields['company'] = $account->company;
//}

But it's no working. It would be great if someone could help me. Thanks, Bjoern

Small bug in sync_sforce_updates5.patch file. When it converts a profile date to a date format that SFDC likes it has the date variables in the wrong order in the mktime function. I've rearranged that line of code to properly convert the date.

There seems to be a timezone issue with the profile date field. It looks it grabs the system timezone and adjusts the date that is fed supplied and modifies it. This is another issue that I need to look into, but at least now my dates are only off by 7 hours.

Here is the same patch, but with the mktime function corrected

Hi Tom,
can you outline the code you've changed. I don't want to go through all the code.

@all
What's the recent status of the project / modules. Can anyone help me with my questions from comments #41 and #42? That would be great.

The patch above is actually a patch that eojthebrave did a while back for syncing fields. I just made one minor modification. If I remember correctly, when syncing the dates the mktime function was formating the month, day, and year in the wrong order.

To see what I actually changed from his original patch, you'll have to run a diff between my patch above and eojthebrave's version 5 patch.

I think I've found a bug ;)

if ($result['error'] == 'NO_METHOD_PROVIDED') {
  db_query("UPDATE {salesforce_logs} l SET l.message = l.message + ' - (%s)' WHERE sid = %d", $result['error'], $row->sid);
  if (user_access('administer salesforce')) {
	drupal_set_message(t('the logged task with the message "%message" was disabled because it has no methods provided in the module. Please post this issue as a bug.', array('%message' => $row->message)));
  }
}

You can see that a database table {salesforce_logs} is updated. This table doesn't exist. Instead we have to use {salesforce_log}.

Has anybody been working on this module since April 2008 ? I wondered if it has been made to work with Drupal 6 and using the latest Salesforce API module ?

Tim, as far as I know the 5.x branch of this module is dead. (see #702614: 5.x branch is no longer relevant. Let's drop it.).

I believe the 6.x branch supercedes this functionality anyway by implementing a generic mapping strategy instead of supporting specific objects.

Marking postponed, pending
#702614: 5.x branch is no longer relevant. Let's drop it.