• Allow users to choose which bootstrap files to use (ie, minified, responsive, etc) via hook_menu
  • Provide a way for bootstrap to be auto-loaded
  • Implement hook_access to create an administrative permission

Patch soon...

CommentFileSizeAuthor
#5 twitter_bootstrap_ui-allow_admin_configuration-1906722-5.patch10.68 KBwbobeirne
#4 twitter_bootstrap_ui-allow_admin_configuration-1906722-2.patch10.66 KBrypit
#1 twitter_bootstrap_ui-allow_admin_configuration-1906722-1.patch9.37 KBrypit

Comments

rypit’s picture

rypit commented
Status: Needs review » Active
StatusFileSize
new twitter_bootstrap_ui-allow_admin_configuration-1906722-1.patch9.37 KB

Here's a patch that adds the functionality mentioned.

Use the patch in #4 instead of the one attached here.

rypit’s picture

rypit commented
Assigned: Unassigned » rypit

Please review.

Note: The autoloading functionality requires cache clear, as it's implementation is in hook_init.

rypit’s picture

rypit commented
Assigned: rypit » Unassigned
Status: Active » Needs review
rypit’s picture

rypit commented
Assigned: rypit » Unassigned
Status: Active » Needs review
StatusFileSize
new twitter_bootstrap_ui-allow_admin_configuration-1906722-2.patch10.66 KB

The patch in #1 has a problem in that it specifies "integration" files which were never originally part of the module, and results in the library files being improperly added. Attached is a patch that addresses that issue, and additionally fixes:

  • Several minor Drupal Coding Standards Issues (multi-line array syntax, function documentation)
  • Moves hook_requirements to the proper location (inside of the module's .install file)
  • Fixes a whitespace issue in the original patch
  • Removes t() in hook_menu, which was against Drupal coding standards
wbobeirne’s picture

wbobeirne commented
StatusFileSize
new twitter_bootstrap_ui-allow_admin_configuration-1906722-5.patch10.68 KB

Attaching a patch for this that also includes changes I made in http://drupal.org/node/1947962. Since this patch moves hook_requirements, and I'm using it in a project, I can't use the patch I posted over there.

mpotter’s picture

mpotter commented
Status: Needs review » Reviewed & tested by the community

Using this in Open Atrium 2 without problems.