E_ALL - Module admin page - .info file compatibility check
catch - November 9, 2007 - 10:18
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | base system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | patchnewbie |
| Status: | closed |
Description
Just downloaded latest devel tarball to my /modules directory (not sites/all/modules, plain old modules), and I got this error:
warning: Invalid argument supplied for foreach() in drupal6/modules/system/system.admin.inc on line 542.
#1
This looks like a good patch for someone new to core development.
#2
This can be caused by a faulty info file. In my case it was the devel-themer module that has the line
dependencies = develrather thendependencies[] = develI'll file a bug report on devel but I'm not sure what is needed in core. Should drupal_parse_info_file force this to be an array? or should we just be checking in system.admin.inc to make sure it's an array?
#3
http://drupal.org/node/191342 was duplicate
#4
Line 542 is from the private function _system_is_incompatible called by system_modules() - which looks like it's breaking system_update_1005() here: http://drupal.org/node/191767
#5
If dependencies not an array in modules info files, then return true to _system_is_incompatible()
#6
rerolled, tested, works
#7
Is the dependencies key initialized to an array if it is not set in the file?
#8
Yes, if the info file does not contain the dependency property, then it is initialized as an empty array.
So I changed the patch to reinit the value to an empty array. Is it ok, or put the original value into array?
like dependencies = devel
makes now $file->info['dependencies'] an empty array
or change it to $file->info['dependencies'] = {devel}, but then it does not need to be set here as incompatible..
#9
I mean what if the dependency key was not used in the .info file? Then the info file reader initializes this to an array, or not? If not, !is_array($file->info['dependencies']) will mark all modules incompatible which have no dependencies.
#10
Yes, the info file reader initializes an empty array in this case, and the patch works correctly with those modules. Does not mark them incompatible.
#11
Whatever happened to "Core doesn't support broken code"?
If a .info file is malformed, then it's a bug in the .info file. This should probably be "won't fix".
#12
weberner: uhm, no. This exact function is to check whether the module is compatible with the current core version at hand or not. Previous info files did not have an array in the dependency key, so there comes the error. We need to handle this error here, as the role of this exact function is to identify broken stuff, so it fiddles with broken stuff by definition.
#13
OK - Looked at the patch more closely, and yes, it looks like you're right. The original description and discussion made me think this was a quick fix to make things work even if the .info file was malformed.
#14
drupal 5 format (http://drupal.org/node/101009)
dependencies = taxonomy comment
does it need to be converted, or the pach is sufficient?
#15
Uhm, no. If the dependencies key is not an array, then that quickly shows us it is not compatible.
#16
Still seeing this in rc2.
warning: Invalid argument supplied for foreach() in modules/system/system.admin.inc on line 580.#17
@gtcaz: Drupal core modules do not have malformed .info file. Can you find which custom module causing this warning? Search for dependencies string in info files. If it does not have [] square brackets then it's a bug in that .info file, and should be fixed.
#18
reroll, please review
#19
No -- I did look for that and couldn't find anything. Attached are all the .info strings for the models and themes I have installed.
#20
@gtcaz: Thanks for the list. I found two malformed info files in event module (issue http://drupal.org/node/209103). Do you see more than two warnings, should I check the other modules too?
#21
and here is a great opportunity to test this patch
test:
1. install drupal
2. add event module 6.x-2.x-dev (7/1/2008)
3. see the warnings on page admin/build/modules
4. apply patch
5. no warnings, the modules with malformed info files are marked incompatible with Drupal core
6. correct dependencies in the info file
7. reload page admin/build/modules, the modules should be compatible now
#22
No, I just see two warnings. Great! I'll apply the patch and report back.
#23
Patch applies cleanly. Errors are gone. Event modules marked incompatible. Excellent!
#24
thanks for the test
#25
Updated the docs a bit, and committed this one. Thanks.
#26
Automatically closed -- issue fixed for two weeks with no activity.