system_modules() breaks updates from 4.7.x to 6.x

drupal 6beta is a beta! not for live production sites. The update is not perfect.

Well, I also played with crazy things like updating from 4.6 to 6.x which is what people would call unsupported, although the update functions are there in the code. With some modifications, it is possible to make it work. I also run into this error, but I was not sure what causes it. Have you been able to identify why system_modules() is causing this error?

BTW the official information is that you should update to 5.x first and then to 6.x, but this is what inpatient people like us skip :)

system_modules() is throwing an E_ALL error as reported here: http://drupal.org/node/190729

I think that same error may be what's breaking this update. Do you have devel module in your modules folder at all?

From k4ml's analysis, I would say that now that system_modules() is in system.admin.inc, and I guess the update system does not include system.admin.inc, this could be a simple function not defined error on the update. That results in a PHP error page with status 200. This should appear in the PHP error log.

As this call is in system_update_1005(), which runs for the 4.7 -> 5.0 update, this does not become a critical error for 6.x (we are not officially supporting updates from previous versions, except 5.x).

k4ml: Please try to use an otherwise unmodified Drupal HEAD adding a

include_once './'. drupal_get_path('module', 'system') .'/system.admin.inc';

line right before the system_modules() call, and watch if your update is fixed. From what I understand, this will probably fix the problem. (We might also get away with

include_once './modules/system/system.admin.inc';

to avoid all API problems, but drupal_get_path() is used elsewhere in system.install in updates, so this will be fine IMHO.)

No, no. As soon as we find simple and straightforward fixes like this, we should ship the fixed version in Drupal 6. Since this is Drupal 6 code, we are sure where system_modules() is defined, and can include that file right away. Now committed the fix for Drupal 6 to include that include_once line.

Let me know if you open other issues for similar problems, as my understanding is that as longs as we still ship these update functions with Drupal 6, it does not hurt if they actually work (even if we do not officially support this upgrade path). So while these kinds of errors are not critical for Drupal 6, we should fix them if the fix are ready, just as it was here.

Well although it's not supported, would there be a particular reason not to patch the update so it works?

cross posted. Back to fixed.

"Yes, you have right with you quote: That Drupal 6 it is a Beta Version."

But it's better to help also, the Drupal Version it is Beta, because this is the Only way to find errors and to help the Drupal Development-Team to fixed all Errors and that the Development can be faster realease the Drupal 6 Version.

I do not know about you, but I also do not have to do this.

But I ask you such silly sayings to somelike; "Hey This is a beta!"

Because I am fed up with the snout of such silly and sick people.

Help rather in such problems as instead of silly sayings to knock.

So I have found no solution. But I have on another subject
the following solution of an user applied which has worked for me. ;)

Maybe this solution can you help :)

Here the code:

Instead of this:

// Recursively traverse the dependencies, looking for incompatible modules
   foreach ($file->info['dependencies'] as $dependency) {
    if (isset($files[$dependency]) && _system_is_incompatible($incompatible, $files, $files[$dependency])) {
      $incompatible[$file->name] = TRUE;
      return TRUE;
    }

you change in the line 537 follow

// Recursively traverse the dependencies, looking for incompatible modules
  if (!empty($group['fields'])) foreach ($group['fields'] as $field_name => $field) {
    if (isset($files[$dependency]) && _system_is_incompatible($incompatible, $files, $files[$dependency])) {
      $incompatible[$file->name] = TRUE;
      return TRUE;
    }

Actually, we left all 4.7 updates in the code, so updating from 4.7 is not at all impossible as it stands. So we should look into fixing this bug indeed. From looking at your insight, it seems that the problem could be with the change of info file formats.

Retitled.

Did the include_once() not fix it then?