I upgraded my site to Drupal 5.3 last night and upgraded img_assist at the same time. Image inserts started failing immediately, though captions were being inserted.

Poking around today, I tracked the problem to an issue in img_assist_display. In my node->images array, the keys were all lowercase. In the code, it was looking for $label to be ucfirsted. For example, "Thumbnail" when the array key was actually "thumbnail".

It isn't pretty, but I changed the section around line 1086 from:

  if (empty($node->images[$label])) {
            return;
  }

to:

  if (empty($node->images[$label])) {
        if (isset($node->images[$label])){
                $label = strtolower($label);
        } else {
            return;
        }
  }

There may be a better place to fix it upstream, but this took care of the symptom and made it so that people could insert images again.

Comments

fmann’s picture

fmann commented

Oops. I meant:

  if (empty($node->images[$label])) {
        if (isset($node->images[strtolower($label)])){
                $label = strtolower($label);
        } else {
            return;
        }
  }
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Could you please test if this bug still exists in the latest development snapshot?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

Without further information I'm obliged to mark this issue won't fix.